Move TyCtxt::mk_x to Ty::new_x where applicable

[BoxyUwU]

Part of rust-lang/compiler-team#616

turns out there's a lot of places we construct Ty this is a ridiculously huge PR :S

r? @oli-obk

[rustbot]

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo

Some changes might have occurred in exhaustiveness checking

cc @Nadrieril

[compiler-errors]

subtree formatting :(

[compiler-errors]

@bors r+ p=10 (very bitrotty!!)

cc subtree owners (@rust-lang/miri, @rust-lang/clippy, and @antoyo for codegen_gcc), you all will need to run rustfmt on your own after this lands.

[bors]

📌 Commit 6ce1c89 has been approved by compiler-errors

It is now in the queue for this repository.

[compiler-errors]

(oh and @bjorn3 too, you're a subtree owner too!)

[compiler-errors]

Noting as a retrospective, but not a blocker of this PR, that we have a lot of code even within the compiler/ directory which is unformatted and remains a bit ugly due to this PR (e.g. Ty::mk_unit(tcx,)).

This is not this PR's fault, but the fault of not having formatting for let-chains in-tree. I've chatted separately with @calebcartwright to understand how we can get provisional formatting into rust sooner than later now that we (T-style) have decided on a new nightly-features formatting policy 😉

[compiler-errors]

Additional nice-to-haves after this PR lands (just the ones that come to mind):

• Replace usages of Ty::new_unit with tcx.types.unit (or vice versa) and similar with the other built-in scalar types for Consistency(TM).
• Replace usages of ty::new_ref that have a fixed mutability with new_imm_ref or new_mut_ref to shorten it and avoid having to go through ty::TyAndMutability -- new_ref should imo only be used when the mutability is being passed in or is variable or something.
• Ideally we'd fix some of the annoying formatting blips (like a lack of spacing after tcx, in the args) before getting full let-chains support...

[bors]

⌛ Testing commit 6ce1c89 with merge b3485f33f946f7556722b47529e79f82632fb229...

[bors]

💔 Test failed - checks-actions

[oli-obk]

@bors r=compiler-errors

[bors]

📌 Commit deda49e has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit deda49e with merge 4dd1719...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 4dd1719 to master...

[rust-timer]

Finished benchmarking commit (4dd1719): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.1%, -0.4%]	10
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-1.1%, -0.4%]	10

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-4.3%, -1.4%]	8
Improvements ✅ (secondary)	-1.5%	[-1.5%, -1.5%]	1
All ❌✅ (primary)	-3.1%	[-4.3%, -1.4%]	8

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 659.042s -> 656.237s (-0.43%)