Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated lines doc to include trailing carriage return note #113512

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Updated lines doc to include trailing carriage return note #113512

merged 1 commit into from
Jul 30, 2023

Conversation

vallentin
Copy link
Contributor

@vallentin vallentin commented Jul 9, 2023 •
edited
Loading

Updated str::lines doc to include explicit info about (trailing) carriage returns.

Reference: #100311

@rustbot
Copy link
Collaborator

rustbot commented Jul 9, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 9, 2023
@workingjubilee workingjubilee added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 30, 2023
@workingjubilee
Copy link
Member

That's weird!

@workingjubilee workingjubilee added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Jul 30, 2023
@workingjubilee
Copy link
Member

Per this comment by the PR's author:

This is a behavioral change tho, and could break people

Indeed it did @thomcc. I just spent time tracking down this change. As suddenly one of my released crates, had tests that started failing

Breaking this was decided in this T-libs-api FCP. It was intended to bring the behavior in line with the (implication by, but not explicit statement of) the documentation, and to make it consistent with std::io::BufRead::lines(). We have made this decision already, so I approve this PR as mere procedure, to explicitly lock-in this promise so that library authors may now rely on it being effectively immutable via this documentation.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 30, 2023

📌 Commit 116aacc has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2023
@workingjubilee
Copy link
Member

r? workingjubilee

@fee1-dead fee1-dead mentioned this pull request Jul 30, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2023
@bors
Auto merge of rust-lang#114236 - fee1-dead-contrib:rollup-m92j7q1, r=…
4c9ac1e 
…fee1-dead

Rollup of 3 pull requests

Successful merges:

 - rust-lang#112151 (Clarify behavior of inclusive bounds in BTreeMap::{lower,upper}_bound)
 - rust-lang#113512 (Updated lines doc to include trailing carriage return note)
 - rust-lang#114203 (Effects: don't print `host` param in diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b97da75 into rust-lang:master Jul 30, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.73.0
Development

Successfully merging this pull request may close these issues.
5 participants
@vallentin @rustbot @workingjubilee @bors @joshtriplett