Rename VecDeque's rotate_left and rotate_right parameters
#113662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Yeah, I agree that this is clearer. @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 14, 2023
Rename VecDeque's `rotate_left` and `rotate_right` parameters This pull request introduces a modification to the `VecDeque` collection, specifically the `rotate_left` and `rotate_right` functions, by renaming the parameter associated with these functions. The rationale behind this change is to provide clearer and more consistent naming for the parameter that specifies the number of places to rotate the double-ended queue. By using `n` as the parameter name in both functions, it becomes easier to understand and remember the purpose of the parameter.
This was referenced Jul 14, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#113599 (Use maybe_body_owned_by for multiple suggestions) - rust-lang#113662 (Rename VecDeque's `rotate_left` and `rotate_right` parameters) - rust-lang#113681 (rustdoc-json: Add test for private supertrait.) - rust-lang#113682 (trait system refactor ping: also apply to nested modules of `solve`) - rust-lang#113685 (Print artifact sizes in `opt-dist`) - rust-lang#113688 (llvm-wrapper: update for LLVM API change) - rust-lang#113692 (tests: adapt for removal of -opaque-pointers in LLVM 17) - rust-lang#113698 (Make it clearer that we're just checking for an RPITIT) - rust-lang#113699 (update Miri) Failed merges: - rust-lang#113625 (Structurally normalize in selection) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a modification to the
VecDequecollection, specifically therotate_leftandrotate_rightfunctions, by renaming the parameter associated with these functions.The rationale behind this change is to provide clearer and more consistent naming for the parameter that specifies the number of places to rotate the double-ended queue. By using
nas the parameter name in both functions, it becomes easier to understand and remember the purpose of the parameter.