inline format!() args from rustc_codegen_llvm to the end (4) #114075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri Some changes might have occurred in exhaustiveness checking cc @Nadrieril Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
wesleywiser
approved these changes
Jul 26, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#113872 (Tweak CGU sorting in a couple of places.) - rust-lang#114053 (CI: fix CMake installation for 32/64 bit `dist` Linux) - rust-lang#114075 (inline format!() args from rustc_codegen_llvm to the end (4)) - rust-lang#114081 (`desugar_doc_comments` cleanups) - rust-lang#114082 (add stable NullaryOp) - rust-lang#114098 (replace atty crate with std's IsTerminal) - rust-lang#114102 (Dont pass `-Zwrite-long-types-to-disk=no` for `ui-fulldeps --stage=1`) r? `@ghost` `@rustbot` modify labels: rollup
Comment on lines
+92
to
+93
| "ItemLocalIds not assigned densely in {pretty_owner}. \ | ||
| Max ItemLocalId = {max}, missing IDs = {missing_items:#?}; seen IDs = {seen_items:#?}" |
There was a problem hiding this comment.
This looks kind of misformatted... Can you try doing something like this?
Suggested change
| "ItemLocalIds not assigned densely in {pretty_owner}. \ | |
| Max ItemLocalId = {max}, missing IDs = {missing_items:#?}; seen IDs = {seen_items:#?}" | |
| "ItemLocalIds not assigned densely in {pretty_owner}. \ | |
| Max ItemLocalId = {max}, missing IDs = {missing_items:#?}; \ | |
| seen IDs = {seen_items:#?}" |
There was a problem hiding this comment.
I did not notice this was merged already, oops 💀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @WaffleLapkin