Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #114083

Closed

Commits on Mar 3, 2023

  1. Make std tests pass on newer Android

    Newer versions of Android forbid the creation of hardlinks as well as
    Unix domain sockets in the /data filesystem via SELinux rules, which
    causes several tests depending on this behavior to fail. So let's
    skip these tests on Android with an #[ignore] directive.
    pcc committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    fed6fce View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Tweak CGU sorting in a couple of places.

    In `base.rs`, tweak how the CGU size interleaving works. Since rust-lang#113777,
    it's much more common to have multiple CGUs with identical sizes. With
    the existing code these same-sized items ended up in the
    opposite-to-desired order due to the stable sorting. The code now starts
    with a reverse sort (like is done in `partitioning.rs`) which gives the
    behaviour we want. This doesn't matter much for perf, but makes profiles
    in `samply` look more like what we expect.
    
    In `partitioning.rs`, we can use `sort_by_key` instead of
    `sort_by_cached_key` because `CGU::size_estimate()` is cheap. (There is
    an identical CGU sort earlier in that function that already uses
    `sort_by_key`.)
    nnethercote committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    8c31219 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Remove -Z diagnostic-width

    ehuss committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2d92f4f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1584e5f View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Rollup merge of rust-lang#102757 - pcc:android-std-tests, r=workingju…

    …bilee
    
    Make std tests pass on newer Android
    
    Newer versions of Android forbid the creation of hardlinks as well as Unix domain sockets in the /data filesystem via SELinux rules, which causes several tests depending on this behavior to fail. So let's skip these tests on Android if we see an EACCES from one of these syscalls. To achieve this, introduce a macro with the horrible name of or_panic_or_skip_on_android_eacces (better suggestions welcome) which skips (returns from) the test if an EACCES return value is seen on Android.
    workingjubilee authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    aa82a34 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#113872 - nnethercote:tweak-cgu-sorting, r=p…

    …nkfelix
    
    Tweak CGU sorting in a couple of places.
    
    In `base.rs`, tweak how the CGU size interleaving works. Since rust-lang#113777, it's much more common to have multiple CGUs with identical sizes. With the existing code these same-sized items ended up in the opposite-to-desired order due to the stable sorting. The code now starts with a reverse sort (like is done in `partitioning.rs`) which gives the behaviour we want. This doesn't matter much for perf, but makes profiles in `samply` look more like what we expect.
    
    In `partitioning.rs`, we can use `sort_by_key` instead of `sort_by_cached_key` because `CGU::size_estimate()` is cheap. (There is an identical CGU sort earlier in that function that already uses `sort_by_key`.)
    
    r? `@pnkfelix`
    workingjubilee authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9a58e4b View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#113942 - ehuss:squelch-bad_path_expr_1, r=f…

    …ee1-dead
    
    Squelch a noisy rustc_expand unittest
    
    The test `rustc_parse::tests::bad_path_expr_1` prints an error message to stderr, circumventing libtest's stderr intercept. This causes noise when running tests, in particular they show up 16 times on the GitHub Actions summary page. The solution here is to not use an error emitter that prints to stderr, and instead check that the correct error is generated.
    workingjubilee authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    187caee View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#114073 - ehuss:remove-z-diagnostic-width, r…

    …=fee1-dead
    
    Remove -Z diagnostic-width
    
    This removes the `-Z diagnostic-width` option since it is ignored and does nothing. `-Z diagnostic-width` was stabilized as `--diagnostic-width` in rust-lang#95635. It is not entirely clear why the `-Z` flag was kept, but in part its final use was removed in rust-lang#102216, but the `-Z` flag itself was not removed.
    workingjubilee authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    7f45211 View commit details
    Browse the repository at this point in the history