Fix ui-fulldeps missing the internal_features lint on stage 0
#114482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
A-testsuite
|
This looks good to me, for what it's worth. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 5, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114287 (update overflow handling in the new trait solver) - rust-lang#114475 (Migrate GUI colors test to original CSS color format) - rust-lang#114482 (Fix ui-fulldeps missing the `internal_features` lint on stage 0) - rust-lang#114490 (Fix a typo in the error reporting for sealed traits.) - rust-lang#114491 (Rename issue rust-lang#114423 test files to include context) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #114102,
ui-fulldeps --stage=1builds using the the stage 0 compiler instead of the stage 1 compiler. That means that the newinternal_featureslint is referencing a lint that does not exist. Gate the flag it properly until the next feature bump.Maybe we should just add ui-fulldeps stage 1 into CI somewhere so this is flagged before landing.