Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #114526

Merged
merged 9 commits into from
Aug 6, 2023
Merged

Rollup of 4 pull requests #114526

merged 9 commits into from
Aug 6, 2023

Commits on Aug 5, 2023

  1. Remove invalid lint when there is a generic argument in prefix path

    @chenyukang
    chenyukang committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    c9be1a7 View commit details
    Browse the repository at this point in the history

  2. Migrate GUI colors test to original CSS color format

    @GuillaumeGomez
    GuillaumeGomez committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    9625fc5 View commit details
    Browse the repository at this point in the history

  3. Also report when goals go from ok to error

    @compiler-errors
    compiler-errors committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    55bf810 View commit details
    Browse the repository at this point in the history

  4. Avoid invalid NaN lint machine-applicable suggestion in const context

    @Urgau
    Urgau committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    b71f2be View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Add FIXME as reminder to restore suggestion later

    @compiler-errors
    compiler-errors authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    3b3e466 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#114486 - Urgau:const-context-nan-suggestion… 

    …-114471, r=compiler-errors

Avoid invalid NaN lint machine-applicable suggestion in const context

This PR removes the machine-applicable suggestion in const context for the `invalid_nan_comparision` lint ~~and replace it with a simple help~~.

Fixes rust-lang#114471
    @matthiaskrgr
    matthiaskrgr authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    1305a43 View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#114503 - chenyukang:yukang-fix-114433-unuse… 

    …d-qualifications, r=compiler-errors

Remove invalid lint when there is a generic argument in prefix path

Fixes rust-lang#114433
    @matthiaskrgr
    matthiaskrgr authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    83d84ff View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#114509 - GuillaumeGomez:migrate-gui-test-co… 

    …lor-28, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
    @matthiaskrgr
    matthiaskrgr authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    e0f04ef View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#114524 - compiler-errors:more-ice-in-uncert… 

    …ainty, r=jackh726

Also ICE when goals go from Ok to Err in new solver

We were just using `?` here, silently downgrading the goal's response from (presumably) maybe to error -- that seems concerning, since this whole check is for detecting goal instability 😅

r? `@lcnr` or `@BoxyUwU`
    @matthiaskrgr
    matthiaskrgr authored Aug 6, 2023
    Configuration menu
    Copy the full SHA
    bf4b1d7 View commit details
    Browse the repository at this point in the history