Rollup of 8 pull requests #114864
Merged
Rollup of 8 pull requests #114864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encountering code like
```rust
fn foo() -> i32 {
match 0 {
1 => return 0,
2 => "",
_ => 1,
}
}
```
Point at the return type and not at the prior arm, as that arm has type
`!` which isn't influencing the arm corresponding to arm `2`.
Fix rust-lang#78124.
This lets us put a version on the impl, too.
…m-ou-se Improve docs for impl Default for ExitStatus This addresses a review comment in rust-lang#106425 (which is on the way to being merged I think). Some of the other followup work is more complicated so I'm going to do individual MRs. ~~Note this branch is on top of rust-lang#106425~~
Fix pthread_attr_union layout on Wasi Fixes rust-lang#114608 Ran the tests as described in https://github.com/rust-lang/rust/blob/master/src/doc/rustc/src/platform-support/wasm32-wasi-preview1-threads.md?plain=1#L125
Point out expectation even if we have `TypeError::RegionsInsufficientlyPolymorphic` just a minor tweak, since saying "one type is more general than the other" kinda sucks if we don't actually point out two types.
…trochenkov
Deny `FnDef` in patterns
We can only see these via `const { .. }` patterns, which are unstable.
cc rust-lang#76001 (tracking issue for inline const pats)
Fixes rust-lang#114658
Fixes rust-lang#114659
…rrors
Point at return type when it influences non-first `match` arm
When encountering code like
```rust
fn foo() -> i32 {
match 0 {
1 => return 0,
2 => "",
_ => 1,
}
}
```
Point at the return type and not at the prior arm, as that arm has type `!` which isn't influencing the arm corresponding to arm `2`.
Fix rust-lang#78124.
add missing feature(error_in_core) Needed to fix feature gate errors in https://github.com/rust-lang/miri-test-libstd/actions/runs/5862810459/job/15895203359. I don't know how doctests are passing in-tree without this feature gate...
…lor-33, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? ``@notriddle``
|
@bors r+ rollup=never p=8 |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: c57393e4f8 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Aug 15, 2023
Closed
|
Finished benchmarking commit (0bdb00d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 632.833s -> 633.84s (0.16%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TypeError::RegionsInsufficientlyPolymorphic#114644 (Point out expectation even if we haveTypeError::RegionsInsufficientlyPolymorphic)FnDefin patterns #114668 (DenyFnDefin patterns)matcharm #114819 (Point at return type when it influences non-firstmatcharm)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup