-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #114951
Rollup of 5 pull requests #114951
Commits on Aug 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7c6bbdb - Browse repository at this point
Copy the full SHA 7c6bbdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d99f1d - Browse repository at this point
Copy the full SHA 0d99f1dView commit details
Commits on Aug 16, 2023
-
Partially revert rust-lang#107200
`Ok(0)` is indeed something the caller may interpret as an error, but that's the *correct* thing to return if the writer can't accept any more bytes.
Configuration menu - View commit details
-
Copy full SHA for 5210f48 - Browse repository at this point
Copy the full SHA 5210f48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 072d8c8 - Browse repository at this point
Copy the full SHA 072d8c8View commit details
Commits on Aug 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1c73248 - Browse repository at this point
Copy the full SHA 1c73248View commit details -
update
thsiserror
to release >= 1.0.46this version is the one containing the workaround for the provider API changes on nightly
Configuration menu - View commit details
-
Copy full SHA for df3819b - Browse repository at this point
Copy the full SHA df3819bView commit details -
Rollup merge of rust-lang#113715 - kadiwa4:lang_items_doc, r=JohnTitor
Unstable Book: update `lang_items` page and split it [`lang_items` rendered](https://github.com/kadiwa4/rust/blob/lang_items_doc/src/doc/unstable-book/src/language-features/lang-items.md), [`start` rendered](https://github.com/kadiwa4/rust/blob/lang_items_doc/src/doc/unstable-book/src/language-features/start.md) Closes rust-lang#110274 Rustonomicon PR: rust-lang/nomicon#413, Rust Book PR: rust-lang/book#3705 A lot of information doesn't belong on the `lang_items` page. I added a separate page for the `start` feature and moved some text into the Rustonomicon because the `lang_items` page should not be a tutorial on how to build a `#![no_std]` executable. The list of existing lang items is too long/unstable, so I removed it. The doctests still don't work. :(
Configuration menu - View commit details
-
Copy full SHA for cd50556 - Browse repository at this point
Copy the full SHA cd50556View commit details -
Rollup merge of rust-lang#114897 - joshtriplett:partial-revert-ok-0, …
…r=m-ou-se Partially revert rust-lang#107200 `Ok(0)` is indeed something the caller may interpret as an error, but that's the *correct* thing to return if the writer can't accept any more bytes.
Configuration menu - View commit details
-
Copy full SHA for 4f14451 - Browse repository at this point
Copy the full SHA 4f14451View commit details -
Rollup merge of rust-lang#114913 - beetrees:escape-double-quote, r=da…
…vidtwco Fix suggestion for attempting to define a string with single quotes Currently attempting to compile `fn main() { let _ = '\\"'; }` will result in the following error message: ``` error: character literal may only contain one codepoint --> src/main.rs:1:21 | 1 | fn main() { let _ = '\\"'; } | ^^^^^ | help: if you meant to write a `str` literal, use double quotes | 1 | fn main() { let _ = "\\""; } | ~~~~~ ``` The suggestion is invalid as it fails to escape the `"`. This PR fixes the suggestion so that it now reads: ``` help: if you meant to write a `str` literal, use double quotes | 1 | fn main() { let _ = "\\\""; } | ~~~~~~ ``` The relevant test is also updated to ensure that this does not regress in future.
Configuration menu - View commit details
-
Copy full SHA for 7ea4de9 - Browse repository at this point
Copy the full SHA 7ea4de9View commit details -
Rollup merge of rust-lang#114931 - Urgau:revert-114052, r=compiler-er…
…rors Revert PR rust-lang#114052 to fix invalid suggestion This PR reverts rust-lang#114052 to fix the invalid suggestion produced by the PR. Unfortunately the invalid suggestion cannot be improved from the current position where it's emitted since we lack enough information (is an assignment?, left or right?, ...) to be able to fix it here. Furthermore the previous wasn't wrong, just suboptimal, contrary to the current one which is just wrong. Added a regression test and commented out some code instead of removing it so we can use it later. Reopens rust-lang#114050 Fixes rust-lang#114925
Configuration menu - View commit details
-
Copy full SHA for 5861815 - Browse repository at this point
Copy the full SHA 5861815View commit details -
Rollup merge of rust-lang#114944 - lqd:fix-thiserror, r=RalfJung
update `thiserror` to version >= 1.0.46 1.0.46 version is the one with [the workaround](dtolnay/thiserror#248) for rust-lang#114839. I'm also encountering this issue, so let's update the dependency so that everyone doesn't have to `./x clean`. Fixes rust-lang#114839. r? `@RalfJung`
Configuration menu - View commit details
-
Copy full SHA for df877c0 - Browse repository at this point
Copy the full SHA df877c0View commit details