Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #115068

Closed
wants to merge 21 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 21 commits August 17, 2023 13:48
tree borrows: more comments in foreign_read transition
pin a version of serde without intransparent unreproducible binary blobs

Serde is [shipping a binary blob in its derive crate](serde-rs/serde#2538), which is highly unexpected and subverts user trust. To make matters worse, the binary is [not even reproducible](serde-rs/serde#2575), making the crate largely unauditable and relinquishing the security benefits of open-source software. Build times are not nearly painful enough to justify forcing users to trust binary blobs.
update recommended RA config

Looks like rust-analyzer.checkOnSave.overrideCommand got renamed to rust-analyzer.check.overrideCommand.
This trait needs `dyn` in modern Rust.

Fixes rust-lang#115042.
…oc-ct-lt, r=cjgillot

Warn on elided lifetimes in associated constants (`ELIDED_LIFETIMES_IN_ASSOCIATED_CONSTANT`)

Elided lifetimes in associated constants (in impls) erroneously resolve to fresh lifetime parameters on the impl since rust-lang#97313. This is not correct behavior (see rust-lang#38831).

I originally opened rust-lang#114716 to fix this, but given the time that has passed, the crater results seem pretty bad: rust-lang#114716 (comment)

This PR alternatively implements a lint against this behavior, and I'm hoping to bump this to deny in a few versions.
…, r=compiler-errors

Fix syntax in E0191 explanation.

This trait needs `dyn` in modern Rust.

Fixes rust-lang#115042.
Fix table issues in platform support documentation (closes rust-lang#115047)

mdBook needs an empty line before and after the table block.
In addition, in the tier-3 list three targets forgot about the host column and therefore showed the notes in the host column.

Closes rust-lang#115047
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 21, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Contributor

bors commented Aug 21, 2023

📌 Commit 25118db has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2023
@bors
Copy link
Contributor

bors commented Aug 21, 2023

⌛ Testing commit 25118db with merge 59bc8fcb3858df446df950e5f3ce40aeb288bcd5...

@rust-log-analyzer
Copy link
Collaborator

The job dist-loongarch64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] countme test:false 2.308
   Compiling synstructure v0.13.0
[RUSTC-TIMING] profile test:false 2.508
   Compiling test-utils v0.0.0 (/checkout/src/tools/rust-analyzer/crates/test-utils)
error: `&` without an explicit lifetime name cannot be used here
   --> crates/test-utils/src/fixture.rs:316:23
    |
316 |     const RAW_SOURCE: &str = include_str!("./minicore.rs");
    |
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #115010 <https://github.com/rust-lang/rust/issues/115010>
    = note: `-D elided-lifetimes-in-associated-constant` implied by `-D warnings`
    = note: `-D elided-lifetimes-in-associated-constant` implied by `-D warnings`
help: use the `'static` lifetime
    |
316 |     const RAW_SOURCE: &'static str = include_str!("./minicore.rs");

[RUSTC-TIMING] stdx test:false 4.140
   Compiling cfg v0.0.0 (/checkout/src/tools/rust-analyzer/crates/cfg)
[RUSTC-TIMING] test_utils test:false 0.276

@bors
Copy link
Contributor

bors commented Aug 21, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 21, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-ia62x4s branch March 16, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table broken in description of target aarch64-unknown-teeos
8 participants