Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split core's PanicInfo and std's PanicInfo #115974

Merged
merged 24 commits into from
Jun 12, 2024
Merged

Split core's PanicInfo and std's PanicInfo #115974

merged 24 commits into from
Jun 12, 2024

Commits on Jun 11, 2024

  1. Split core's PanicInfo and std's PanicInfo.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e3e8153 View commit details
    Browse the repository at this point in the history

  2. Document difference between core and std's PanicInfo.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a519dc8 View commit details
    Browse the repository at this point in the history

  3. Add core::panic::PanicInfo::payload() for compatibility.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    16dfc6d View commit details
    Browse the repository at this point in the history

  4. Fix doc link.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    331b8a3 View commit details
    Browse the repository at this point in the history

  5. Update doc comment about core::panicking.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    83dd214 View commit details
    Browse the repository at this point in the history

  6. Remove core::panic::PanicInfo::internal_constructor. 

    It no longer needs to be public.
    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0266bbf View commit details
    Browse the repository at this point in the history

  7. Remove std::panic::PanicInfo::internal_constructor+set_payload. 

    We can just set the payload immediately in the constructor,
and the constructor does not need to be public.
    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0642cb2 View commit details
    Browse the repository at this point in the history

  8. Mark some PanicInfo methods as #[inline] for consistency.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    0087d89 View commit details
    Browse the repository at this point in the history

  9. Move downcasting panic payload to str to a function.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4e356f3 View commit details
    Browse the repository at this point in the history

  10. Use unnamed lifetimes for [..]Payload impl blocks.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    22f7399 View commit details
    Browse the repository at this point in the history

  11. Impl Display for PanicPayload to simplify things.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    1642de3 View commit details
    Browse the repository at this point in the history

  12. Reorder body of begin_panic for consistency. 

    In the other functions, we put the struct and impl blocks first,
such that the return expression can be at the end of the body as usual.
    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    bab26b0 View commit details
    Browse the repository at this point in the history

  13. Fix invalid markdown/html.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6b2d7c4 View commit details
    Browse the repository at this point in the history

  14. Formatting.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b6180a9 View commit details
    Browse the repository at this point in the history

  15. Rename std::panic::PanicInfo to PanicHookInfo.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    64e56db View commit details
    Browse the repository at this point in the history

  16. Fix deprecation version.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3854357 View commit details
    Browse the repository at this point in the history

  17. Move deprecation of std::panic::PanicInfo to 1.80.0.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    f5fe82f View commit details
    Browse the repository at this point in the history

  18. Downcast panic payload to String too in example.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ce0bc8b View commit details
    Browse the repository at this point in the history

  19. Add note on panic payload type.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    32bfe70 View commit details
    Browse the repository at this point in the history

  20. Mention core's PanicInfo in error.md.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    877a26f View commit details
    Browse the repository at this point in the history

  21. Fix display of panic message in recursive panic.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    fb0990d View commit details
    Browse the repository at this point in the history

  22. Add PanicHookInfo::payload_as_str().

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    de07c1a View commit details
    Browse the repository at this point in the history

  23. Bump deprecation of std's PanicInfo alias to 1.82.0.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a345c3d View commit details
    Browse the repository at this point in the history

  24. Formatting.

    @m-ou-se
    m-ou-se committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a6e23b1 View commit details
    Browse the repository at this point in the history