Add assembly test to make sure that inlining works as expected when closures inherit target features #116078

eduardosm · 2023-09-22T21:23:01Z

Closes #108338 (the added test proves that it is working correctly)

rustbot · 2023-09-22T21:23:09Z

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2023-09-23T12:30:55Z

@bors r+

bors · 2023-09-23T12:30:58Z

📌 Commit 3393f86 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…eature, r=Mark-Simulacrum Add assembly test to make sure that inlining works as expected when closures inherit target features Closes rust-lang#108338 (the added test proves that it is working correctly)

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#115794 (Do not create a DerefLen place for `Box<[T]>`.) - rust-lang#116069 (Fix debug printing of tuple) - rust-lang#116075 (Document panics on unsigned wrapping_div/rem calls (rust-lang#116063)) - rust-lang#116076 (Add Zba, Zbb, and Zbs as target features for riscv64-linux-android) - rust-lang#116078 (Add assembly test to make sure that inlining works as expected when closures inherit target features) r? `@ghost` `@rustbot` modify labels: rollup

…eature, r=Mark-Simulacrum Add assembly test to make sure that inlining works as expected when closures inherit target features Closes rust-lang#108338 (the added test proves that it is working correctly)

…llaumeGomez Rollup of 6 pull requests Successful merges: - rust-lang#114454 (Replace `HashMap` with `IndexMap` in pattern binding resolve ) - rust-lang#116069 (Fix debug printing of tuple) - rust-lang#116076 (Add Zba, Zbb, and Zbs as target features for riscv64-linux-android) - rust-lang#116078 (Add assembly test to make sure that inlining works as expected when closures inherit target features) - rust-lang#116096 (Make FnDef 1-ZST in LLVM debuginfo.) - rust-lang#116116 (Rename the legacy feature gating macro) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2023-09-24T13:26:25Z

⌛ Testing commit 3393f86 with merge 74d6a45...

…ture, r=Mark-Simulacrum Add assembly test to make sure that inlining works as expected when closures inherit target features Closes rust-lang#108338 (the added test proves that it is working correctly)

bors · 2023-09-24T14:05:37Z

💔 Test failed - checks-actions

…losures inherit target features

eduardosm · 2023-09-24T14:39:13Z

Added opt-level=3 to the test. I guess x86_64-gnu-nopt disables optimizations by default.

Mark-Simulacrum · 2023-09-24T22:46:57Z

@bors r+

bors · 2023-09-24T22:46:58Z

📌 Commit 5aba873 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2023-09-25T05:39:13Z

⌛ Testing commit 5aba873 with merge 67ad3c2...

bors · 2023-09-25T07:27:15Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 67ad3c2 to master...

rust-timer · 2023-09-25T10:59:00Z

Finished benchmarking commit (67ad3c2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	3.6%	[3.6%, 3.6%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	0.3%	[-2.5%, 3.1%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 630.411s -> 631.29s (0.14%)
Artifact size: 317.18 MiB -> 317.22 MiB (0.01%)

…_target_feature_sgx, r=Mark-Simulacrum Fix closure-inherit-target-feature test for SGX platform PR rust-lang#116078 adds the `closure-inherit-target-feature.rs` test that checks the generated assembly code for closures. These checks explicitly check the presence of `ret` instructions. This is incompatible with the SGX target as it explicitly rewrites all `ret` instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform. cc: `@jethrogb`

…_target_feature_sgx, r=Mark-Simulacrum Fix closure-inherit-target-feature test for SGX platform PR rust-lang#116078 adds the `closure-inherit-target-feature.rs` test that checks the generated assembly code for closures. These checks explicitly check the presence of `ret` instructions. This is incompatible with the SGX target as it explicitly rewrites all `ret` instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform. cc: ``@jethrogb``

…_target_feature_sgx, r=Mark-Simulacrum Fix closure-inherit-target-feature test for SGX platform PR rust-lang#116078 adds the `closure-inherit-target-feature.rs` test that checks the generated assembly code for closures. These checks explicitly check the presence of `ret` instructions. This is incompatible with the SGX target as it explicitly rewrites all `ret` instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform. cc: ```@jethrogb```

Rollup merge of rust-lang#117082 - fortanix:raoul/fix_closure_inherit_target_feature_sgx, r=Mark-Simulacrum Fix closure-inherit-target-feature test for SGX platform PR rust-lang#116078 adds the `closure-inherit-target-feature.rs` test that checks the generated assembly code for closures. These checks explicitly check the presence of `ret` instructions. This is incompatible with the SGX target as it explicitly rewrites all `ret` instructions to mitigate LVI vulnerabilities of certain processors. This PR simply ignores these tests for the SGX platform. cc: ```@jethrogb```

rustbot assigned Mark-Simulacrum Sep 22, 2023

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2023

matthiaskrgr mentioned this pull request Sep 23, 2023

Rollup of 5 pull requests #116110

Closed

GuillaumeGomez mentioned this pull request Sep 24, 2023

Rollup of 6 pull requests #116119

Closed

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 24, 2023

Add assembly test to make sure that inlining works as expected when c…

5aba873

…losures inherit target features

eduardosm force-pushed the closure-inherit-target-feature branch from 3393f86 to 5aba873 Compare September 24, 2023 14:38

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2023

bors merged commit 67ad3c2 into rust-lang:master Sep 25, 2023
12 checks passed

rustbot added this to the 1.74.0 milestone Sep 25, 2023

eduardosm deleted the closure-inherit-target-feature branch September 25, 2023 16:32

eduardosm mentioned this pull request Sep 25, 2023

Stabilize target_feature_11 #116114

Open

raoulstrackx mentioned this pull request Oct 23, 2023

Fix closure-inherit-target-feature test for SGX platform #117082

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add assembly test to make sure that inlining works as expected when closures inherit target features #116078

Add assembly test to make sure that inlining works as expected when closures inherit target features #116078

eduardosm commented Sep 22, 2023

rustbot commented Sep 22, 2023

Mark-Simulacrum commented Sep 23, 2023

bors commented Sep 23, 2023

bors commented Sep 24, 2023

This comment has been minimized.

bors commented Sep 24, 2023

eduardosm commented Sep 24, 2023

Mark-Simulacrum commented Sep 24, 2023

bors commented Sep 24, 2023

bors commented Sep 25, 2023

bors commented Sep 25, 2023

rust-timer commented Sep 25, 2023

Add assembly test to make sure that inlining works as expected when closures inherit target features #116078

Add assembly test to make sure that inlining works as expected when closures inherit target features #116078

Conversation

eduardosm commented Sep 22, 2023

rustbot commented Sep 22, 2023

Mark-Simulacrum commented Sep 23, 2023

bors commented Sep 23, 2023

bors commented Sep 24, 2023

This comment has been minimized.

bors commented Sep 24, 2023

eduardosm commented Sep 24, 2023

Mark-Simulacrum commented Sep 24, 2023

bors commented Sep 24, 2023

bors commented Sep 25, 2023

bors commented Sep 25, 2023

rust-timer commented Sep 25, 2023

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size