Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the TypedArena::alloc_from_iter specialization. #116370

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Remove the TypedArena::alloc_from_iter specialization. #116370

merged 2 commits into from
Oct 5, 2023

Commits on Oct 3, 2023

  1. Remove the TypedArena::alloc_from_iter specialization. 

    It was added in rust-lang#78569. It's complicated and doesn't actually help
performance.

Also, add a comment explaining why the two `alloc_from_iter` functions
are so different.
    @nnethercote
    nnethercote committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    816383c View commit details
    Browse the repository at this point in the history

  2. Optimize some alloc_from_iter call sites. 

    There's no need to collect an iterator into a `Vec`, or to call
`into_iter` at the call sites.
    @nnethercote
    nnethercote committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    a2051dd View commit details
    Browse the repository at this point in the history