Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted small cleanups #116474

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Assorted small cleanups #116474

merged 6 commits into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Remove unneeded dependency.

    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    442a66d View commit details
    Browse the repository at this point in the history

  2. Remove unused FileName::CfgSpec.

    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    108e541 View commit details
    Browse the repository at this point in the history

  3. Factor out insert_or_error. 

    It appears identically as a closure in two functions.

Also change its return type from `bool` to `Option<()>` so it can be
used with `?`.
    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e49a147 View commit details
    Browse the repository at this point in the history

  4. Remove unneeded dependency. 

    Also sort them.
    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4b51a3e View commit details
    Browse the repository at this point in the history

  5. Remove unneeded features.

    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    093b435 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary pub.

    @nnethercote
    nnethercote committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    e7dabc9 View commit details
    Browse the repository at this point in the history