Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #117013

Merged
merged 21 commits into from
Oct 21, 2023
Merged

Rollup of 8 pull requests #117013

merged 21 commits into from
Oct 21, 2023

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    e8d4fb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Add stable Instance::body() and RustcInternal trait

    The `Instance::body()` returns a monomorphized body.
    
    For that, we had to implement visitor that monomorphize types and
    constants. We are also introducing the RustcInternal trait that will
    allow us to convert back from Stable to Internal.
    
    Note that this trait is not yet visible for our users as it depends on
    Tables. We should probably add a new trait that can be exposed.
    celinval committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6ed2a76 View commit details
    Browse the repository at this point in the history
  2. std: freebsd build update.

    since freebsd 11 had been removed, minimum is now 12.
    devnexen committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9a963e8 View commit details
    Browse the repository at this point in the history
  3. Remove obsolete comment

    celinval authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6e643e1 View commit details
    Browse the repository at this point in the history
  4. Typo suggestion to change bindings with leading underscore

    When encountering a binding that isn't found but has a typo suggestion
    for a binding with a leading underscore, suggest changing the binding
    definition instead of the use place.
    
    Fix rust-lang#60164.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b0d17f3 View commit details
    Browse the repository at this point in the history
  5. Mention into_iter on borrow errors suggestions when appropriate

    If we encounter a borrow error on `vec![1, 2, 3].iter()`, suggest
    `into_iter`.
    
    Fix rust-lang#68445.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    88bccf4 View commit details
    Browse the repository at this point in the history
  6. Point at assoc fn definition on type param divergence

    When the number of type parameters in the associated function of an impl
    and its trait differ, we now *always* point at the trait one, even if it
    comes from a foreign crate. When it is local, we point at the specific
    params, when it is foreign, we point at the whole associated item.
    
    Fix rust-lang#69944.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    939a224 View commit details
    Browse the repository at this point in the history
  7. changes from feedback

    devnexen committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f479142 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Configuration menu
    Copy the full SHA
    dca4295 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a17ff82 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e164944 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    319693a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ff02d92 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#114521 - devnexen:std_fbsd_13_upd, r=cuviper

    std: freebsd build update.
    
    since freebsd 11 had been removed, minimum is now 12.
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    90671a0 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#116911 - estebank:issue-85378, r=oli-obk

    Suggest relaxing implicit `type Assoc: Sized;` bound
    
    Fix rust-lang#85378.
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    3fd7175 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#116917 - Zalathar:injection, r=cjgillot

    coverage: Simplify the injection of coverage statements
    
    This is a follow-up to rust-lang#116046 that I left out of that PR because I didn't want to make it any larger.
    
    After the various changes we've made to how coverage data is stored and transferred, the old code structure for injecting coverage statements into MIR is built around a lot of constraints that don't exist any more. We can simplify it by replacing it with a handful of loops over the BCB node/edge counters and the BCB spans.
    
    ---
    
    `@rustbot` label +A-code-coverage
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    ad574d9 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#116961 - estebank:issue-60164, r=oli-obk

    Typo suggestion to change bindings with leading underscore
    
    When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place.
    
    Fix rust-lang#60164.
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    c5dd84d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#116964 - celinval:smir-mono-body, r=oli-obk

    Add stable Instance::body() and RustcInternal trait
    
    The `Instance::body()` returns a monomorphized body.
    
    For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal.
    
    Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed.
    
    The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first.
    
    r? ```@oli-obk```
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    b703519 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#116974 - Zalathar:signature-spans, r=oli-ob…

    …k,cjgillot
    
    coverage: Fix inconsistent handling of function signature spans
    
    While doing some more cleanup of `spans`, I noticed a strange inconsistency in how function signatures are handled. Normally the function signature span is treated as though it were executable as part of the start of the function, but in some cases the signature span disappears entirely from coverage, for no obvious reason.
    
    This is caused by the fact that spans created by `CoverageSpan::for_fn_sig` don't add the span to their `merged_spans` field (unlike normal statement/terminator spans). In cases where the span-processing code looks at those merged spans, it thinks the signature span is no longer visible and deletes it.
    
    Adding the signature span to `merged_spans` resolves the inconsistency.
    
    (Prior to rust-lang#116409 this wouldn't have been possible, because there was no case in the old `CoverageStatement` enum representing a signature. Now that `merged_spans` is just a list of spans, that's no longer an obstacle.)
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    e9df0b6 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#116990 - estebank:issue-68445, r=cjgillot

    Mention `into_iter` on borrow errors suggestions when appropriate
    
    If we encounter a borrow error on `vec![1, 2, 3].iter()`, suggest `into_iter`.
    
    Fix rust-lang#68445.
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    dd66bc8 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#116995 - estebank:issue-69944, r=compiler-e…

    …rrors
    
    Point at assoc fn definition on type param divergence
    
    When the number of type parameters in the associated function of an impl and its trait differ, we now *always* point at the trait one, even if it comes from a foreign crate. When it is local, we point at the specific params, when it is foreign, we point at the whole associated item.
    
    Fix rust-lang#69944.
    matthiaskrgr authored Oct 21, 2023
    Configuration menu
    Copy the full SHA
    e9d18f5 View commit details
    Browse the repository at this point in the history