Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #118745

Closed
wants to merge 15 commits into from

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    ad6dd6c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    85e73c1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e836561 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. Add unstable -Zdefault-hidden-visibility cmdline flag for rustc.

    The new flag has been described in the Major Change Proposal at
    rust-lang/compiler-team#656
    anforowicz committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    1a0829c View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Add instance evaluation and methods to read alloc

    The instance evaluation is needed to handle intrinsics such as
    `type_id` and `type_name`.
    
    Since we now use Allocation to represent all evaluated constants,
    provide a few methods to help process the data inside an allocation.
    celinval committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4c9e842 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cb6463 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a0e7e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9e15c49 View commit details
    Browse the repository at this point in the history
  5. remove redundant imports

    detects redundant imports that can be eliminated.
    
    for rust-lang#117772 :
    
    In order to facilitate review and modification, split the checking code and
    removing redundant imports code into two PR.
    surechen committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4b64fbf View commit details
    Browse the repository at this point in the history
  6. Extend tidy alphabetical checking to tests/.

    This is desired for rust-lang#118702.
    nnethercote committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    5d16c54 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#118150 - roblabla:new-win7-targets, r=david…

    …twco
    
    Add new targets {x86_64,i686}-win7-windows-msvc
    
    This PR adds two new Tier 3 targets, x86_64-win7-windows-msvc and i686-win7-windows-msvc, that aim to support targeting Windows 7 after the `*-pc-windows-msvc` target drops support for it (slated to happen in 1.76.0).
    
    # Tier 3 target policy
    
    > At this tier, the Rust project provides no official support for a target, so we place minimal requirements on the introduction of targets.
    >
    > A proposed new tier 3 target must be reviewed and approved by a member of the compiler team based on these requirements. The reviewer may choose to gauge broader compiler team consensus via a [Major Change Proposal (MCP)](https://forge.rust-lang.org/compiler/mcp.html).
    >
    > A proposed target or target-specific patch that substantially changes code shared with other targets (not just target-specific code) must be reviewed and approved by the appropriate team for that shared code before acceptance.
    >
    >  - A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)
    
    This is me, ```@roblabla``` on github.
    
    > - Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.
    
    I went with naming the target `x86_64-win7-windows-msvc`, inserting the `win7` in the vendor field (usually set to to `pc`). This is done to avoid ecosystem churn, as quite a few crates have `cfg(target_os = "windows")` or `cfg(target_env = "msvc")`, but nearly no `cfg(target_vendor = "pc")`. Since my goal is to be able to seamlessly swap to the `win7` target, I figured it'd be easier this way.
    
    >  - Target names should not introduce undue confusion or ambiguity unless absolutely necessary to maintain ecosystem compatibility. For example, if the name of the target makes people extremely likely to form incorrect beliefs about what it targets, the name should be changed or augmented to disambiguate it.
    
    I believe the naming is pretty explicit.
    
    >  - If possible, use only letters, numbers, dashes and underscores for the name. Periods (`.`) are known to cause issues in Cargo.
    
    The name comforms to this requirement.
    
    > - Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.
    >    - The target must not introduce license incompatibilities.
    >    - Anything added to the Rust repository must be under the standard Rust license (`MIT OR Apache-2.0`).
    >    - The target must not cause the Rust tools or libraries built for any other host (even when supporting cross-compilation to the target) to depend on any new dependency less permissive than the Rust licensing policy. This applies whether the dependency is a Rust crate that would require adding new license exceptions (as specified by the `tidy` tool in the rust-lang/rust repository), or whether the dependency is a native library or binary. In other words, the introduction of the target must not cause a user installing or running a version of Rust or the Rust tools to be subject to any new license requirements.
    >    - Compiling, linking, and emitting functional binaries, libraries, or other code for the target (whether hosted on the target itself or cross-compiling from another target) must not depend on proprietary (non-FOSS) libraries. Host tools built for the target itself may depend on the ordinary runtime libraries supplied by the platform and commonly used by other applications built for the target, but those libraries must not be required for code generation for the target; cross-compilation to the target must not require such libraries at all. For instance, `rustc` built for the target may depend on a common proprietary C runtime library or console output library, but must not depend on a proprietary code generation library or code optimization library. Rust's license permits such combinations, but the Rust project has no interest in maintaining such combinations within the scope of Rust itself, even at tier 3.
    >    - "onerous" here is an intentionally subjective term. At a minimum, "onerous" legal/licensing terms include but are *not* limited to: non-disclosure requirements, non-compete requirements, contributor license agreements (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms, requirements conditional on the employer or employment of any particular Rust developers, revocable terms, any requirements that create liability for the Rust project or its developers or users, or any requirements that adversely affect the livelihood or prospects of the Rust project or its developers or users.
    
    As far as I understand it, this target has exactly the same legal situation as the existing Tier 1 x86_64-pc-windows-msvc.
    
    > - Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.
    >   -   This requirement does not prevent part or all of this policy from being cited in an explicit contract or work agreement (e.g. to implement or maintain support for a target). This requirement exists to ensure that a developer or team responsible for reviewing and approving a target does not face any legal threats or obligations that would prevent them from freely exercising their judgment in such approval, even if such judgment involves subjective matters or goes beyond the letter of these requirements.
    
    Understood.
    
    > - Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.
    
    This target supports the whole libstd surface, since it's essentially reusing all of the x86_64-pc-windows-msvc target. Understood.
    
    > - The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.
    
    Wrote some documentation on how to build, test and cross-compile the target in the `platform-support` part. Hopefully it's enough to get started.
    
    > - Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via ````@`)``` to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.
    >   - Backlinks such as those generated by the issue/PR tracker when linking to an issue or PR are not considered a violation of this policy, within reason. However, such messages (even on a separate repository) must not generate notifications to anyone involved with a PR who has not requested such notifications.
    
    Understood.
    
    > - Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.
    >   - In particular, this may come up when working on closely related targets, such as variations of the same architecture with different features. Avoid introducing unconditional uses of features that another variation of the target may not have; use conditional compilation or runtime detection, as appropriate, to let each target run code supported by that target.
    
    Understood.
    
    > If a tier 3 target stops meeting these requirements, or the target maintainers no longer have interest or time, or the target shows no signs of activity and has not built for some time, or removing the target would improve the quality of the Rust codebase, we may post a PR to remove it; any such PR will be CCed to the target maintainers (and potentially other people who have previously worked on the target), to check potential interest in improving the situation.
    
    Understood.
    GuillaumeGomez authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b61b48a View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#118417 - anforowicz:default-hidden-visibili…

    …ty, r=TaKO8Ki
    
    Add unstable `-Zdefault-hidden-visibility` cmdline flag for `rustc`.
    
    The new flag has been described in the Major Change Proposal at
    rust-lang/compiler-team#656
    GuillaumeGomez authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3481a75 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#118692 - surechen:remove_unused_imports, r=…

    …petrochenkov
    
    remove redundant imports
    
    detects redundant imports that can be eliminated.
    
    for rust-lang#117772 :
    
    In order to facilitate review and modification, split the checking code and removing redundant imports code into two PR.
    
    r? ````@petrochenkov````
    GuillaumeGomez authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    7db9e23 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#118694 - celinval:smir-alloc-methods, r=ouz-a

    Add instance evaluation and methods to read an allocation in StableMIR
    
    The instance evaluation is needed to handle intrinsics such as `type_id` and `type_name`.
    
    Since we now use Allocation to represent all evaluated constants, provide a few methods to help process the data inside an allocation.
    
    I've also started to add a structured way to get information about the compilation target machine. For now, I've only added information needed to process an allocation.
    
    r? ````@ouz-a````
    GuillaumeGomez authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    6f4ce6c View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#118737 - nnethercote:tidy-alphabetical-in-t…

    …estsa, r=Nilstrieb
    
    Extend tidy alphabetical checking to `tests/`.
    
    This is desired for rust-lang#118702.
    
    r? ````@Nilstrieb````
    GuillaumeGomez authored Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a3e37ff View commit details
    Browse the repository at this point in the history