Rollup of 5 pull requests #119002

workingjubilee · 2023-12-15T22:08:18Z

Successful merges:

Collect lang items from AST, get rid of GenericBound::LangItemTrait #118396 (Collect lang items from AST, get rid of GenericBound::LangItemTrait)
Don't pass lint back out of lint decorator #118727 (Don't pass lint back out of lint decorator)
Make CStr documentation consistent ("nul" instead of "null") #118956 (Make CStr documentation consistent ("nul" instead of "null"))
Remove an unneeded allocation #118981 (Remove an unneeded allocation)
Link to is_benchmark from the Ipv6Addr::is_global documentation #118998 (Link to is_benchmark from the Ipv6Addr::is_global documentation)

r? @ghost
@rustbot modify labels: rollup

All other relevant is_* methods are mentioned in the list of addresses here, is_benchmarking has been the only one missing.

…cjgillot Collect lang items from AST, get rid of `GenericBound::LangItemTrait` r? `@cjgillot` cc rust-lang#115178 Looking forward, the work to remove `QPath::LangItem` will also be significantly more difficult, but I plan on doing it as well. Specifically, we have to change: 1. A lot of `rustc_ast_lowering` for things like expr `..` 2. A lot of astconv, since we actually instantiate lang and non-lang paths quite differently. 3. A ton of diagnostics and clippy lints that are special-cased via `QPath::LangItem` Meanwhile, it was pretty easy to remove `GenericBound::LangItemTrait`, so I just did that here.

…affleLapkin Don't pass lint back out of lint decorator Change the decorator function in the signature of the `emit_lint`/`span_lint`/etc family of methods from `impl for<'a, 'b> FnOnce(&'b mut DiagnosticBuilder<'a, ()>) -> &'b mut DiagnosticBuilder<'a, ()>` to `impl for<'a, 'b> FnOnce(&'b mut DiagnosticBuilder<'a, ()>)`. I consider it easier to read this way, especially when there's control flow involved. r? nnethercote though feel free to reassign

Make CStr documentation consistent ("nul" instead of "null") "nul" is used in method names and appears more often in the documentation than "null", so make all instances "nul" to keep it consistent.

Remove an unneeded allocation This removes an unneeded allocation in `<&[hir::GenericParam<'_>] as NextTypeParamName>::next_type_param_name`

…ilee Link to is_benchmark from the Ipv6Addr::is_global documentation All other relevant is_* methods are mentioned in the list of addresses here, is_benchmarking has been the only one missing.

workingjubilee · 2023-12-15T22:08:37Z

@bors r+ rollup=never p=5

bors · 2023-12-15T22:08:40Z

📌 Commit 4b447b8 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2023-12-15T22:09:50Z

⌛ Testing commit 4b447b8 with merge ca5c68a...

bors · 2023-12-16T00:06:24Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing ca5c68a to master...

rust-timer · 2023-12-16T00:07:50Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#118396	Collect lang items from AST, get rid of `GenericBound::Lang…	`6a29ea32583dc50f9d49004e3b08701f15a0f73c` (link)
#118727	Don't pass lint back out of lint decorator	`b0837863dddb9cbfc0e465ff39b4ede517115f0f` (link)
#118956	Make CStr documentation consistent ("nul" instead of "null")	`7a4cff445a4394a20303d14f1cbe51f876051aa4` (link)
#118981	Remove an unneeded allocation	`883fbd74e779a5cf6b9291f9af4d14f2f413590d` (link)
#118998	Link to is_benchmark from the Ipv6Addr::is_global documenta…	`ddda68d2703af61f1c8b71dfc7c1fa5f5d1b56e5` (link)

previous master: a96d57bdb6

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-12-16T04:39:47Z

Finished benchmarking commit (ca5c68a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.5%]	40
Regressions ❌ (secondary)	0.4%	[0.1%, 0.7%]	36
Improvements ✅ (primary)	-0.3%	[-0.3%, -0.3%]	1
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.2%	[-0.3%, 0.5%]	41

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.7%, 3.0%]	4
Regressions ❌ (secondary)	3.5%	[2.2%, 4.0%]	5
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[-0.5%, 3.0%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	1
Regressions ❌ (secondary)	2.4%	[2.4%, 2.4%]	2
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.8%]	1
Improvements ✅ (secondary)	-1.1%	[-1.4%, -0.8%]	2
All ❌✅ (primary)	-0.2%	[-0.8%, 0.5%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.894s -> 671.592s (-0.04%)
Artifact size: 312.51 MiB -> 312.57 MiB (0.02%)

lqd · 2023-12-16T06:50:29Z

@rust-timer build 6a29ea3

rust-timer · 2023-12-16T08:11:31Z

Finished benchmarking commit (6a29ea3): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.1%, 0.5%]	38
Regressions ❌ (secondary)	0.4%	[0.1%, 0.8%]	31
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	2
All ❌✅ (primary)	0.3%	[0.1%, 0.5%]	38

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.8%	[0.5%, 3.0%]	3
Regressions ❌ (secondary)	3.1%	[2.1%, 3.7%]	5
Improvements ✅ (primary)	-1.4%	[-2.1%, -0.8%]	2
Improvements ✅ (secondary)	-1.9%	[-2.1%, -1.6%]	2
All ❌✅ (primary)	0.5%	[-2.1%, 3.0%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.6%, 1.6%]	4
Regressions ❌ (secondary)	2.9%	[2.7%, 3.0%]	2
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-1.0%	[-1.5%, -0.7%]	3
All ❌✅ (primary)	0.7%	[-0.5%, 1.6%]	5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 671.894s -> 673.945s (0.31%)
Artifact size: 312.51 MiB -> 312.61 MiB (0.03%)

danielhuang and others added 17 commits December 14, 2023 19:05

Update c_str.rs

d031795

Update c_str.rs

f2f9b1d

Remove an unneeded allocation

8142e85

Don't pass lint back out of lint decorator

7f565ed

Fix comments

252d99a

Collect lang items from AST

ad00641

banish hir::GenericBound::LangItemTrait

fc010de

Simplify instantiate_poly_trait_ref

653ca5a

Appease the tools: clippy, rustdoc

553c3c4

Cfg remove lang items in doctest

04fafd6

Fix enforcement of generics for associated items

bc1ca6b

Add link to is_benchmark from the Ipv6Addr::is_global documentation

4728279

All other relevant is_* methods are mentioned in the list of addresses here, is_benchmarking has been the only one missing.

Rollup merge of rust-lang#118956 - danielhuang:patch-2, r=workingjubilee

5e85fec

Make CStr documentation consistent ("nul" instead of "null") "nul" is used in method names and appears more often in the documentation than "null", so make all instances "nul" to keep it consistent.

Rollup merge of rust-lang#118981 - krtab:onelessalloc, r=compiler-errors

3d94fc9

Remove an unneeded allocation This removes an unneeded allocation in `<&[hir::GenericParam<'_>] as NextTypeParamName>::next_type_param_name`

Rollup merge of rust-lang#118998 - jstasiak:improve-doc, r=workingjub…

4b447b8

…ilee Link to is_benchmark from the Ipv6Addr::is_global documentation All other relevant is_* methods are mentioned in the list of addresses here, is_benchmarking has been the only one missing.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 16, 2023

bors merged commit ca5c68a into rust-lang:master Dec 16, 2023
12 checks passed

rustbot added this to the 1.76.0 milestone Dec 16, 2023

This was referenced Dec 16, 2023

Add feature to disable the panic_impl provided by std #100156

Closed

Make IMPLIED_BOUNDS_ENTAILMENT into a hard error from a lint #117984

Merged

Add REDUNDANT_LIFETIMES lint to detect lifetimes which are semantically redundant #118391

Merged

workingjubilee deleted the rollup-dbfet7s branch December 16, 2023 03:04

rustbot added the perf-regression Performance regression. label Dec 16, 2023

This comment has been minimized.

Sign in to view

pnkfelix mentioned this pull request Dec 19, 2023

Collect lang items from AST, get rid of GenericBound::LangItemTrait #118396

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #119002

Rollup of 5 pull requests #119002

workingjubilee commented Dec 15, 2023

workingjubilee commented Dec 15, 2023

bors commented Dec 15, 2023

bors commented Dec 15, 2023

bors commented Dec 16, 2023

rust-timer commented Dec 16, 2023

rust-timer commented Dec 16, 2023

lqd commented Dec 16, 2023

This comment has been minimized.

rust-timer commented Dec 16, 2023

Rollup of 5 pull requests #119002

Rollup of 5 pull requests #119002

Conversation

workingjubilee commented Dec 15, 2023

workingjubilee commented Dec 15, 2023

bors commented Dec 15, 2023

bors commented Dec 15, 2023

bors commented Dec 16, 2023

rust-timer commented Dec 16, 2023

rust-timer commented Dec 16, 2023

Overall result: ❌ regressions - ACTION NEEDED

lqd commented Dec 16, 2023

This comment has been minimized.

rust-timer commented Dec 16, 2023

Overall result: ❌ regressions - ACTION NEEDED