Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent Result<usize, Box<T>> as ScalarPair(i64, ptr) #121668

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Represent Result<usize, Box<T>> as ScalarPair(i64, ptr) #121668

merged 5 commits into from
Mar 13, 2024

Commits on Feb 27, 2024

  1. allow using scalarpair with a common prim of ptr/ptr-sized-int

    @erikdesjardins
    erikdesjardins committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4dabbcb View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. simplify common prim computation

    @erikdesjardins
    erikdesjardins committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    f574c65 View commit details
    Browse the repository at this point in the history

  2. fix test failure due to differing u64 alignment on different targets

    @erikdesjardins
    erikdesjardins committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8e40b17 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. make check lines for int/ptr common prim test more permissive 

    It seems that LLVM 17 doesn't fully optimize out unwrap_unchecked.

We can just loosen the check lines to account for this, since we don't
really care about the exact instructions, we just want to make sure that
inttoptr/ptrtoint aren't used for Box.
    @erikdesjardins
    erikdesjardins committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    5ccada6 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. refine common_prim test 

    Co-authored-by: Scott McMurray <[email protected]>
    @erikdesjardins @scottmcm
    erikdesjardins and scottmcm committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9f55200 View commit details
    Browse the repository at this point in the history