-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #123023
Rollup of 8 pull requests #123023
Commits on Mar 21, 2024
-
Provide structured suggestion for unconstrained generic constant
``` error: unconstrained generic constant --> $DIR/const-argument-if-length.rs:18:10 | LL | pad: [u8; is_zst::<T>()], | ^^^^^^^^^^^^^^^^^^^ | help: try adding a `where` bound | LL | pub struct AtLeastByte<T: ?Sized> where [(); is_zst::<T>()]: { | ++++++++++++++++++++++++++ ``` Detect when the constant expression isn't `usize` and suggest casting: ``` error: unconstrained generic constant --> f300.rs:6:10 | 6 | bb::<{!N}>(); | ^^^^ -Ztrack-diagnostics: created at compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs:3539:36 | help: try adding a `where` bound | 5 | fn b<const N: bool>() where [(); {!N} as usize]: { | ++++++++++++++++++++++++++ ``` Fix rust-lang#122395.
Configuration menu - View commit details
-
Copy full SHA for 6b24fdf - Browse repository at this point
Copy the full SHA 6b24fdfView commit details
Commits on Mar 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fb65ca1 - Browse repository at this point
Copy the full SHA fb65ca1View commit details -
Clean up unnecessary headers/flags in coverage mir-opt tests
These headers and flags were historically needed, but are now unnecessary due to various changes in how coverage information is stored in MIR.
Configuration menu - View commit details
-
Copy full SHA for b5ee20f - Browse repository at this point
Copy the full SHA b5ee20fView commit details -
CFI: Handle dyn with no principal
In user-facing Rust, `dyn` always has at least one predicate following it. Unfortunately, because we filter out marker traits from receivers at callsites and `dyn Sync` is, for example, legal, this results in us having `dyn` types with no predicates on occasion in our alias set encoding. This patch handles cases where there are no predicates in a `dyn` type which are relevant to its alias set. Fixes rust-lang#122998
Configuration menu - View commit details
-
Copy full SHA for ea45185 - Browse repository at this point
Copy the full SHA ea45185View commit details -
In
pretty_print_type()
, printasync fn
futures' paths instead of ……spans. This makes `-Zprint-type-sizes`'s output easier to read, because the name of an `async fn` is more immediately recognizable than its span. I also deleted the comment "FIXME(eddyb) should use `def_span`." because it appears to have already been fixed by commit 67727aa.
Configuration menu - View commit details
-
Copy full SHA for aaf49b4 - Browse repository at this point
Copy the full SHA aaf49b4View commit details -
CFI: Support arbitrary receivers
Previously, we only rewrote `&self` and `&mut self` receivers. By instantiating the method from the trait definition, we can make this work work with arbitrary legal receivers instead.
Configuration menu - View commit details
-
Copy full SHA for 40f41e7 - Browse repository at this point
Copy the full SHA 40f41e7View commit details -
Temporarily remove nnethercote from the review rotation.
I will be on vacation for the next three weeks. I will re-add myself when I return.
Configuration menu - View commit details
-
Copy full SHA for 50b49ae - Browse repository at this point
Copy the full SHA 50b49aeView commit details
Commits on Mar 25, 2024
-
Inline and remove
Parser::parse_expr_tuple_field_access_float
.It has a single call site, and afterwards all the calls to `parse_expr_tuple_field_access` are in a single method, which is nice.
Configuration menu - View commit details
-
Copy full SHA for 42066b0 - Browse repository at this point
Copy the full SHA 42066b0View commit details -
Remove
next_token
handling fromparse_expr_tuple_field_access
.It's clearer at the call site.
Configuration menu - View commit details
-
Copy full SHA for 90eeb3d - Browse repository at this point
Copy the full SHA 90eeb3dView commit details -
Change
parse_expr_tuple_field_access
.Pass in the span for the field rather than using `prev_token`. Also rename it `mk_expr_tuple_field_access`, because it doesn't do any actual parsing, it just creates an expression with what it's given. Not much of a clarity win by itself, but unlocks additional subsequent simplifications.
Configuration menu - View commit details
-
Copy full SHA for 9c09116 - Browse repository at this point
Copy the full SHA 9c09116View commit details -
Clarify
parse_dot_suffix_expr
.For the `MiddleDot` case, current behaviour: - For a case like `1.2`, `sym1` is `1` and `sym2` is `2`, and `self.token` holds `1.2`. - It creates a new ident token from `sym1` that it puts into `self.token`. - Then it does `bump_with` with a new dot token, which moves the `sym1` token into `prev_token`. - Then it does `bump_with` with a new ident token from `sym2`, which moves the `dot` token into `prev_token` and discards the `sym1` token. - Then it does `bump`, which puts whatever is next into `self.token`, moves the `sym2` token into `prev_token`, and discards the `dot` token altogether. New behaviour: - Skips creating and inserting the `sym1` and dot tokens, because they are unnecessary. - This also demonstrates that the comment about `Spacing::Alone` is wrong -- that value is never used. That comment was added in rust-lang#77250, and AFAICT it has always been incorrect. The commit also expands comments. I found this code hard to read previously, the examples in comments make it easier.
Configuration menu - View commit details
-
Copy full SHA for dce0f7f - Browse repository at this point
Copy the full SHA dce0f7fView commit details -
Rollup merge of rust-lang#122802 - estebank:unconstrained-generic-con…
…st, r=Nadrieril Provide structured suggestion for unconstrained generic constant ``` error: unconstrained generic constant --> $DIR/const-argument-if-length.rs:18:10 | LL | pad: [u8; is_zst::<T>()], | ^^^^^^^^^^^^^^^^^^^ | help: try adding a `where` bound | LL | pub struct AtLeastByte<T: ?Sized> where [(); is_zst::<T>()]: { | ++++++++++++++++++++++++++ ``` Detect when the constant expression isn't `usize` and suggest casting: ``` error: unconstrained generic constant --> f300.rs:6:10 | 6 | bb::<{!N}>(); | ^^^^ -Ztrack-diagnostics: created at compiler/rustc_trait_selection/src/traits/error_reporting/type_err_ctxt_ext.rs:3539:36 | help: try adding a `where` bound | 5 | fn b<const N: bool>() where [(); {!N} as usize]: { | ++++++++++++++++++++++++++ ``` Fix rust-lang#122395.
Configuration menu - View commit details
-
Copy full SHA for 5c5d36c - Browse repository at this point
Copy the full SHA 5c5d36cView commit details -
Rollup merge of rust-lang#122858 - nnethercote:tweak-parse_dot_suffix…
…_expr, r=est31 Tweak `parse_dot_suffix_expr` I find this function hard to understand, so I rewrote it. r? `@est31`
Configuration menu - View commit details
-
Copy full SHA for 05e9668 - Browse repository at this point
Copy the full SHA 05e9668View commit details -
Rollup merge of rust-lang#122923 - kpreid:print-async-def, r=compiler…
…-errors In `pretty_print_type()`, print `async fn` futures' paths instead of spans. This makes `-Zprint-type-sizes`'s output easier to read, because the name of an `async fn` is more immediately recognizable than its span. This change will also synergize with my other `-Zprint-type-sizes` PR rust-lang#122922 which prints the type of child futures being awaited. I also deleted the comment "FIXME(eddyb) should use `def_span`." because it appears to have already been fixed by commit 67727aa.
Configuration menu - View commit details
-
Copy full SHA for ff460c5 - Browse repository at this point
Copy the full SHA ff460c5View commit details -
Rollup merge of rust-lang#122990 - SkiFire13:transmute-may-copy, r=jh…
…pratt Clarify transmute example The example claims using an iterator will copy the entire vector, but this is not true in practice thanks to internal specializations in the stdlib (see https://godbolt.org/z/cnxo3MYs5 for confirmation that this doesn't reallocate nor iterate over the vec's elements). Since neither the copy nor the optimization is guaranteed I opted for saying that they _may_ happen.
Configuration menu - View commit details
-
Copy full SHA for 8e6689b - Browse repository at this point
Copy the full SHA 8e6689bView commit details -
Rollup merge of rust-lang#122995 - Zalathar:flags-mir-opt, r=Mark-Sim…
…ulacrum Clean up unnecessary headers/flags in coverage mir-opt tests During rust-lang#122542, I noticed that some of the headers and flags I had copied over from `tests/mir-opt/instrument_coverage.rs` were unnecessary. And while working to remove those, I noticed even more that could be removed or replaced.
Configuration menu - View commit details
-
Copy full SHA for 1970644 - Browse repository at this point
Copy the full SHA 1970644View commit details -
Rollup merge of rust-lang#123003 - maurer:dyn-empty, r=compiler-errors
CFI: Handle dyn with no principal In user-facing Rust, `dyn` always has at least one predicate following it. Unfortunately, because we filter out marker traits from receivers at callsites and `dyn Sync` is, for example, legal, this results in us having `dyn` types with no predicates on occasion in our alias set encoding. This patch handles cases where there are no predicates in a `dyn` type which are relevant to its alias set. Fixes rust-lang#122998 r? workingjubilee
Configuration menu - View commit details
-
Copy full SHA for 5ce2a15 - Browse repository at this point
Copy the full SHA 5ce2a15View commit details -
Rollup merge of rust-lang#123005 - maurer:cfi-arbitrary-receivers, r=…
…compiler-errors CFI: Support complex receivers Right now, we only support rewriting `&self` and `&mut self` into `&dyn MyTrait` and `&mut dyn MyTrait`. This expands it to handle the full gamut of receivers by calculating the receiver based on *substitution* rather than based on a rewrite. This means that, for example, `Arc<Self>` will become `Arc<dyn MyTrait>` appropriately with this change. This approach also allows us to support associated type constraints as well, so we will correctly rewrite `&self` into `&dyn MyTrait<T=i32>`, for example. r? `@workingjubilee`
Configuration menu - View commit details
-
Copy full SHA for 4ccb5a7 - Browse repository at this point
Copy the full SHA 4ccb5a7View commit details -
Rollup merge of rust-lang#123020 - nnethercote:rm-nnethercote-review,…
… r=nnethercote Temporarily remove nnethercote from the review rotation. I will be on vacation for the next three weeks. I will re-add myself when I return. r? `@nnethercote`
Configuration menu - View commit details
-
Copy full SHA for 778e707 - Browse repository at this point
Copy the full SHA 778e707View commit details