-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip Codegen{GCC,Cranelift} when using CI rustc #123373
Conversation
Signed-off-by: onur-ozkan <[email protected]>
rustbot has assigned @albertlarsan68. Use |
If you test stage2 rather than stage1, cg_clif and cg_gcc would be built, right? |
No, they will not. Here some more context: rust/src/bootstrap/src/core/build_steps/compile.rs Lines 1698 to 1709 in 36b6f9b
|
Do anyone have time to review this? @rust-lang/bootstrap |
@bors r+ This seems OK for now (given that it sounds like it doesn't work to not do this anyway), but I'd expect it to be possible for CI-downloaded rustc to link against a locally built cranelift/gcc codegen backend. |
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#120900 (std: use `stream_position` where applicable) - rust-lang#123373 (skip Codegen{GCC,Cranelift} when using CI rustc) - rust-lang#123618 (Discard overflow obligations in `impl_may_apply`) - rust-lang#123905 (rustdoc: check redundant explicit links with correct itemid) - rust-lang#123915 (improve documentation slightly regarding some pointer methods) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123373 - onur-ozkan:skip-codegen, r=Mark-Simulacrum skip Codegen{GCC,Cranelift} when using CI rustc CI rustc uses the default codegen backend, therefore we can't run `CodegenGCC` and `CodegenCranelift` tests when using it. cc `@bjorn3` (to make sure I am not doing anything wrong) Fixes rust-lang#123331
CI rustc uses the default codegen backend, therefore we can't run
CodegenGCC
andCodegenCranelift
tests when using it.cc @bjorn3 (to make sure I am not doing anything wrong)
Fixes #123331