Test updating llvm18 docker image #123960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
I've been getting strange test failures on the #122178 LLVM18 builder in a PR of mine, and they seemed completely unrelated. Trying to reproduce the test failures locally showed they also happened on master, hence this CI test PR which forces the image to be rebuilt. The llvm18 builder uses ubuntu 24.04, and seems to contain release candidates or unstable versions of in particular gdb (gdb 15 here, which is expected to release in the next few weeks). While the llvm17 builder uses the latest release, 14.2. The gdb version in that builder is
My and @Kobzol's understanding is that the builder does not yet fail on master because the cached docker image has not been rebuilt since the (I don't know if the issue is a gdb bug, a breaking change, or if we have to do something in our debug helpers or tests. The timing seems very close to the last change mentioned in another gdb regression https://sourceware.org/bugzilla/show_bug.cgi?id=30330 -- incidentally this other regression is marked as fixed since 02/2024 but it seems cc @cuviper |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
Disable two debuginfo tests failing under the future GDB 15 release As seen in rust-lang#123960, it seems two of our debuginfo tests started failing on gdb 15, which is also already in use in the `x86_64-gnu-llvm-18` builder: CI will randomly start to fail whenever this cached docker image expires. This PR disables the following two tests under gdb 15+, to prevent future CI failures. - `tests/debuginfo/include_string.rs` - `tests/debuginfo/vec-slices.rs` This seems very much related to https://sourceware.org/bugzilla/show_bug.cgi?id=30330 and https://sourceware.org/bugzilla/show_bug.cgi?id=31517 -- and I just now saw rust-lang#122751 as well, where one of these bugzilla issues and one of the two test failures here was previously mentioned. I don't know whether these are unexpected gdb changes, or if we need to change our tests as it seems some of the gdb changes are definitely intentional, so I'll just cc `@rust-lang/wg-debugging` and `@tromey.` (In the same area, `tests/debuginfo/unsized.rs` was previously disabled due to https://sourceware.org/bugzilla/show_bug.cgi?id=30330. This issue has been fixed but I don't believe our test passes, so it's in the same boat as the 2 above regarding whether this test is expected to work or needs changes as well) r? wg-debugging I've confirmed this is enough to have CI pass on gdb 15 with the llvm 18 builder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is expected to fail
r? ghost