Delay span bug when Self kw resolves to DefKind::{Mod,Trait}
#123997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
compiler-errors
force-pushed
the
self-res
branch
from
2c7b8d4
to
6288a72
Compare
fmease
approved these changes
Apr 17, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#122813 (Qualifier tweaking) - rust-lang#122883 (refactor clippy in bootstrap) - rust-lang#123997 (Delay span bug when `Self` kw resolves to `DefKind::{Mod,Trait}`) - rust-lang#124045 (Reinstate nnethercote to the review rotation.) - rust-lang#124051 (Fix empty-set symbol in comments) - rust-lang#124052 (Make the comments for `ReturnDest` variants doc comments) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 17, 2024
Rollup merge of rust-lang#123997 - compiler-errors:self-res, r=fmease Delay span bug when `Self` kw resolves to `DefKind::{Mod,Trait}` Catch the case where `kw::Self` is recovered in the parser and causes us to subsequently resolve `&self`'s implicit type to something that's not a type. This check could be made more accurate, though I'm not sure how hard we have to try here. Fixes rust-lang#123988
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch the case where
kw::Selfis recovered in the parser and causes us to subsequently resolve&self's implicit type to something that's not a type.This check could be made more accurate, though I'm not sure how hard we have to try here.
Fixes #123988