Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #124906

Closed
wants to merge 19 commits into from

Commits on Apr 14, 2024

  1. Configuration menu
    Copy the full SHA
    829338a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c26072 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2ec337c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13f7623 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2d3a9a5 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2024

  1. Configuration menu
    Copy the full SHA
    397a35d View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Configuration menu
    Copy the full SHA
    1d9d671 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Simplify use crate::rustc_foo::bar occurrences.

    They can just be written as `use rustc_foo::bar`, which is far more
    standard. (I didn't even know that a `crate::` prefix was valid.)
    nnethercote committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b68b920 View commit details
    Browse the repository at this point in the history
  2. Update cc crate to v1.0.97

    jfgoog committed May 8, 2024
    Configuration menu
    Copy the full SHA
    fbc2abd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    767711b View commit details
    Browse the repository at this point in the history
  4. Simplify clippy lint.

    reitermarkus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3fe0be9 View commit details
    Browse the repository at this point in the history
  5. Simplify suggestion.

    reitermarkus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7531eaf View commit details
    Browse the repository at this point in the history
  6. Use generic NonZero.

    reitermarkus committed May 8, 2024
    Configuration menu
    Copy the full SHA
    bd8e565 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#123344 - pietroalbini:pa-unused-imports, r=…

    …Nilstrieb
    
    Remove braces when fixing a nested use tree into a single item
    
    [Back in 2019](rust-lang#56645) I added rustfix support for the `unused_imports` lint, to automatically remove them when running `cargo fix`. For the most part this worked great, but when removing all but one childs of a nested use tree it turned `use foo::{Unused, Used}` into `use foo::{Used}`. This is slightly annoying, because it then requires you to run `rustfmt` to get `use foo::Used`.
    
    This PR automatically removes braces and the surrouding whitespace when all but one child of a nested use tree are unused. To get it done I had to add the span of the nested use tree to the AST, and refactor a bit the code I wrote back then.
    
    A thing I noticed is, there doesn't seem to be any `//@ run-rustfix` test for fixing the `unused_imports` lint. I created a test in `tests/suggestions` (is that the right directory?) that for now tests just what I added in the PR. I can followup in a separate PR to add more tests for fixing `unused_lints`.
    
    This PR is best reviewed commit-by-commit.
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    14bdce1 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#124587 - reitermarkus:use-generic-nonzero, …

    …r=dtolnay
    
    Generic `NonZero` post-stabilization changes.
    
    Tracking issue: rust-lang#120257
    
    r? `@dtolnay`
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    d174a49 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#124775 - matthiaskrgr:boom, r=jieyouxu

    crashes: add lastest batch of crash tests
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    6b92d9a View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#124869 - compiler-errors:keyword, r=Nilstrieb

    Make sure we don't deny macro vars w keyword names
    
    `$async:ident`, etc are all valid.
    
    Fixes rust-lang#124862
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    cae0a91 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#124876 - nnethercote:rm-use-crate-rustc_foo…

    …, r=compiler-errors
    
    Simplify `use crate::rustc_foo::bar` occurrences.
    
    They can just be written as `use rustc_foo::bar`, which is far more standard. (I didn't even know that a `crate::` prefix was valid.)
    
    r? `@eholk`
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    a12aff2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#124892 - jfgoog:update-cc, r=workingjubilee

    Update cc crate to v1.0.97
    matthiaskrgr authored May 8, 2024
    Configuration menu
    Copy the full SHA
    dcf1c57 View commit details
    Browse the repository at this point in the history