Fix read_buf uses in std
#125404
Merged
Fix read_buf uses in std
#125404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Waiting to see how a bit more of the discussion plays out given #78485 (comment) |
|
It seems like there should be tests for this? |
|
Hm, not much comment since then... @a1phyr Can probably accept this with added tests that clarify the behavior we implement internally and the doc-comment on the Read trait that they mention. |
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #130710) made this pull request unmergeable. Please resolve the merge conflicts. |
a1phyr
force-pushed
the
fix-read_buf-uses
branch
from
50196d3
to
2b39f85
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
a1phyr
force-pushed
the
fix-read_buf-uses
branch
2 times, most recently
from
f578a8a
to
9bf69aa
Compare
a1phyr
force-pushed
the
fix-read_buf-uses
branch
from
9bf69aa
to
d77664b
Compare
|
So the primary effect of this PR is to guard against calls to |
|
Yes! |
|
Cool. @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#125404 (Fix `read_buf` uses in `std`) - rust-lang#130866 (Allow instantiating object trait binder when upcasting) - rust-lang#130922 (Reference UNSPECIFIED instead of INADDR_ANY in join_multicast_v4) - rust-lang#130924 (Make clashing_extern_declarations considering generic args for ADT field) - rust-lang#130939 (rustdoc: update `ProcMacro` docs section on helper attributes) - rust-lang#130940 (Revert space-saving operations) - rust-lang#130944 (Allow instantiating trait object binder in ptr-to-ptr casts) - rust-lang#130953 (Rename a few tests to make tidy happier) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 28, 2024
Rollup merge of rust-lang#125404 - a1phyr:fix-read_buf-uses, r=workingjubilee Fix `read_buf` uses in `std` Following lib-team decision here: rust-lang#78485 (comment) Guard against the pathological behavior of both returning an error and performing a read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following lib-team decision here: #78485 (comment)
Guard against the pathological behavior of both returning an error and performing a read.