Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak type inference for const operands in inline asm #125558

Merged
merged 9 commits into from
Aug 6, 2024
Merged

Tweak type inference for const operands in inline asm #125558

merged 9 commits into from
Aug 6, 2024

Commits on Jul 25, 2024

  1. Tweak type inference for const operands in inline asm 

    Previously these would be treated like integer literals and default to
`i32` if a type could not be determined. To allow for
forward-compatibility with `str` constants in the future, this PR
changes type inference to use an unbound type variable instead.

The actual type checking is deferred until after typeck where we still
ensure that the final type for the `const` operand is an integer type.
    @Amanieu
    Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4d74712 View commit details
    Browse the repository at this point in the history

  2. Work around rust-lang#96304 by ignoring one test case

    @Amanieu
    Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    575fc72 View commit details
    Browse the repository at this point in the history

  3. apply fix suggested by lcnr

    @folkertdev @Amanieu
    folkertdev authored and Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    97738e1 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Amanieu d'Antras <[email protected]>
    @folkertdev @Amanieu
    folkertdev and Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c77b569 View commit details
    Browse the repository at this point in the history

  5. rustfmt

    @Amanieu
    Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d4ca1ac View commit details
    Browse the repository at this point in the history

  6. use ErrorGuaranteed from emit

    @folkertdev @Amanieu
    folkertdev authored and Amanieu committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    be66415 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. separate test file for invalid sym operand

    @folkertdev @Amanieu
    folkertdev authored and Amanieu committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b73077e View commit details
    Browse the repository at this point in the history

  2. separate test file for invalid const operand

    @folkertdev @Amanieu
    folkertdev authored and Amanieu committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    47e6db5 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. add needs-asm-support to invalid-sym-operand

    @folkertdev @Amanieu
    folkertdev authored and Amanieu committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    eb726a5 View commit details
    Browse the repository at this point in the history