Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #125960

Merged
merged 30 commits into from
Jun 4, 2024
Merged

Rollup of 8 pull requests #125960

merged 30 commits into from
Jun 4, 2024

Commits on Apr 28, 2024

  1. Configuration menu
    Copy the full SHA
    fc1e52a View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Change pedantically incorrect OnceCell/OnceLock wording

    While the semantic intent of a OnceCell/OnceLock is that it can only be written
    to once (upon init), the fact of the matter is that both these types offer a
    `take(&mut self) -> Option<T>` mechanism that, when successful, resets the cell
    to its initial state, thereby technically allowing it to be written to again.
    
    Despite the fact that this can only happen with a mutable reference (generally
    only used during the construction of the OnceCell/OnceLock), it would be
    incorrect to say that the type itself as a whole categorically prevents being
    initialized or written to more than once (since it is possible to imagine an
    identical type only without the `take()` method that actually fulfills that
    contract).
    
    To clarify, change "that cannot be.." to "that nominally cannot.." and add a
    note to OnceCell about what can be done with an `&mut Self` reference.
    mqudsi committed May 24, 2024
    Configuration menu
    Copy the full SHA
    65dffc1 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2024

  1. Configuration menu
    Copy the full SHA
    a126c11 View commit details
    Browse the repository at this point in the history
  2. make the fact that arm-none-eabi is a group of targets the first thin…

    …g you see on the page.
    Lokathor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    f646314 View commit details
    Browse the repository at this point in the history
  3. update armv4t docs

    Lokathor committed May 28, 2024
    Configuration menu
    Copy the full SHA
    144adf6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d8704b9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bb1f5c3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    94d4040 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Configuration menu
    Copy the full SHA
    5f0043a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f58bf91 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Configuration menu
    Copy the full SHA
    b320ac7 View commit details
    Browse the repository at this point in the history
  2. Remove stray "this"

    tbu- committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    4576027 View commit details
    Browse the repository at this point in the history
  3. Add regression test

    oli-obk committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    aebe8a7 View commit details
    Browse the repository at this point in the history
  4. Hide some follow-up errors

    oli-obk committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    61c4b7f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4dec6bb View commit details
    Browse the repository at this point in the history
  6. Store indices of generic args instead of spans, as the actual entries…

    … are unused, just the number of entries is checked.
    
    The indices will be used in a follow-up commit
    oli-obk committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    24af952 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2e3842b View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    adb2ac0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    063b26a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    108a1e5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    d498eb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    273b990 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#124486 - beetrees:vectorcall-tracking-issue…

    …, r=ehuss
    
    Add tracking issue and unstable book page for `"vectorcall"` ABI
    
    Originally added in 2015 by rust-lang#30567, the Windows `"vectorcall"` ABI didn't have a tracking issue until now.
    
    Tracking issue: rust-lang#124485
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    aa13b89 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#125504 - mqudsi:once_nominal, r=cuviper

    Change pedantically incorrect OnceCell/OnceLock wording
    
    While the semantic intent of a OnceCell/OnceLock is that it can only be written to once (upon init), the fact of the matter is that both these types offer a `take(&mut self) -> Option<T>` mechanism that, when successful, resets the cell to its initial state, thereby [technically allowing it to be written to again](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=415c023a6ae1ef35f371a2d3bb1aa735)
    
    Despite the fact that this can only happen with a mutable reference (generally only used during the construction of the OnceCell/OnceLock), it would be incorrect to say that the type itself as a whole *categorically* prevents being initialized or written to more than once (since it is possible to imagine an identical type only without the `take()` method that actually fulfills that contract).
    
    To clarify, change "that cannot be.." to "that nominally cannot.." and add a note to OnceCell about what can be done with an `&mut Self` reference.
    
    ```@rustbot``` label +A-rustdocs
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    d5a0422 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#125608 - oli-obk:subsequent_lifetime_errors…

    …, r=BoxyUwU
    
    Avoid follow-up errors if the number of generic parameters already doesn't match
    
    fixes rust-lang#125604
    
    best reviewed commit-by-commit
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    0dc6550 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#125690 - Lokathor:arm-maintainer-reorg, r=e…

    …huss
    
    ARM Target Docs Update
    
    Updates the ARM target docs, drawing more attention to the `arm-none-eabi` target group by placing all targets *within* that group as a sub-list in the Table of Contents.
    
    Also updates the `armv4t-none-eabi` page (maintainer signoff: I'm that target's maintainer) to clarify that the page covers the arm version and the thumb version of the target, but that the target group page has the full info because there's nothing really specific to say for those targets.
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6c2cf0b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#125750 - compiler-errors:expect, r=lcnr

    Align `Term` methods with `GenericArg` methods, add `Term::expect_*`
    
    * `Term::ty` -> `Term::as_type`.
    * `Term::ct` -> `Term::as_const`.
    * Adds `Term::expect_type` and `Term::expect_const`, and uses them in favor of `.ty().unwrap()`, etc.
    
    I could also shorten these to `as_ty` and then do `GenericArg::as_ty` as well, but I do think the `as_` is important to signal that this is a conversion method, and not a getter, like `Const::ty` is.
    
    r? types
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    b477f89 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#125818 - Urgau:print-check-cfg-no-values, r…

    …=petrochenkov
    
    Handle no values cfgs with `--print=check-cfg`
    
    This PR fix a bug with `--print=check-cfg`, where no values cfgs where not printed since we only printed cfgs that had at least one values.
    
    The representation I choose is `CFG=`, since it doesn't correspond to any valid config, it also IMO nicely complements the `values()` (to indicate no values). Representing the absence of value by the absence of the value.
    
    So for `cfg(feature, values())` we would print `feature=`.
    
    I also added the missing tracking issue number in the doc.
    
    r? ```@petrochenkov```
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    756af9d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#125909 - fmease:rustdoc-add-test-synth-blan…

    …ket-impls, r=GuillaumeGomez
    
    rustdoc: add a regression test for a former blanket impl synthesis ICE
    
    Fixes rust-lang#119792 (also passes in rust-lang#125907 in case you were wondering).
    
    r? rustdoc
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    6abb7fb View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#125919 - tbu-:pr_fix_typo, r=lqd

    Remove stray "this"
    jieyouxu authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    a04a603 View commit details
    Browse the repository at this point in the history