-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to clarify the confusingly-named RustDev
and RustcDev
steps
#126779
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
I always get soo confused by these names, thanks for documenting it! Maybe we could also mention in the comment all the main components contained in the archive? Btw, I think that actual renaming would have far reaching consequences here 😆 Since these archives are consumed by downstream users. r? @Kobzol |
We could probably rename the bootstrap steps, but then the steps wouldn't match the tarball filenames, which would be a different source of confusion. I think the tarballs are only used by bootstrap itself as part of |
It's hard to estimate how many people use these, that's for sure. |
Thanks! @bors r+ rollup |
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#126720 (Ignore `branch-protection-check-IBT` run-make test) - rust-lang#126779 (Try to clarify the confusingly-named `RustDev` and `RustcDev` steps) - rust-lang#126782 (Support absolute source paths in bootstrap) - rust-lang#126783 (Fix issue number for the `tcplistener_into_incoming` feature) - rust-lang#126843 (Allow "C-unwind" fn to have C variadics) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126779 - Zalathar:rust-dev, r=Kobzol Try to clarify the confusingly-named `RustDev` and `RustcDev` steps When trying to track down how the downloaded LLVM gets built and bundled, I was greatly confused by these step names. I wasn't sure whether I could just rename them (since they correspond to the filename of the resulting tarball), but I at least wanted to leave behind some signposts to reduce confusion.
When trying to track down how the downloaded LLVM gets built and bundled, I was greatly confused by these step names.
I wasn't sure whether I could just rename them (since they correspond to the filename of the resulting tarball), but I at least wanted to leave behind some signposts to reduce confusion.