Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to clarify the confusingly-named RustDev and RustcDev steps #126779

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

Zalathar
Copy link
Contributor

When trying to track down how the downloaded LLVM gets built and bundled, I was greatly confused by these step names.

I wasn't sure whether I could just rename them (since they correspond to the filename of the resulting tarball), but I at least wanted to leave behind some signposts to reduce confusion.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 21, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jun 21, 2024

I always get soo confused by these names, thanks for documenting it! Maybe we could also mention in the comment all the main components contained in the archive?

Btw, I think that actual renaming would have far reaching consequences here 😆 Since these archives are consumed by downstream users.

r? @Kobzol

@rustbot rustbot assigned Kobzol and unassigned Mark-Simulacrum Jun 21, 2024
@Zalathar
Copy link
Contributor Author

We could probably rename the bootstrap steps, but then the steps wouldn't match the tarball filenames, which would be a different source of confusion.

I think the tarballs are only used by bootstrap itself as part of download-rustc/download-ci-llvm (at least that seems to be the intention), so renaming them would at the very least require corresponding changes to the download/extraction code. And it might have other consequences I'm not aware of, so such a rename would require coordination with people who know more about what happens to the built tarballs in general.

@Kobzol
Copy link
Contributor

Kobzol commented Jun 21, 2024

It's hard to estimate how many people use these, that's for sure. RustDev is marked as internal only, so that one should probably be fine to rename, but RustcDev is actually a rustup-installable component (you can do rustup component add rustc-dev), so that one we definitely shouldn't rename.

@Kobzol
Copy link
Contributor

Kobzol commented Jun 23, 2024

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 23, 2024

📌 Commit 16cf268 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#126720 (Ignore `branch-protection-check-IBT` run-make test)
 - rust-lang#126779 (Try to clarify the confusingly-named `RustDev` and `RustcDev` steps)
 - rust-lang#126782 (Support absolute source paths in bootstrap)
 - rust-lang#126783 (Fix issue number for the `tcplistener_into_incoming` feature)
 - rust-lang#126843 (Allow "C-unwind" fn to have C variadics)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 98cc130 into rust-lang:master Jun 23, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jun 23, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2024
Rollup merge of rust-lang#126779 - Zalathar:rust-dev, r=Kobzol

Try to clarify the confusingly-named `RustDev` and `RustcDev` steps

When trying to track down how the downloaded LLVM gets built and bundled, I was greatly confused by these step names.

I wasn't sure whether I could just rename them (since they correspond to the filename of the resulting tarball), but I at least wanted to leave behind some signposts to reduce confusion.
@Zalathar Zalathar deleted the rust-dev branch June 23, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants