Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make has_attr check behind effects feature #127144

Closed
wants to merge 1 commit into from
Closed

Make has_attr check behind effects feature #127144

wants to merge 1 commit into from

Conversation

fee1-dead
Copy link
Member

attempt to fix the performance regression in #120639.

cc #110395

r? project-const-traits

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 30, 2024
@fee1-dead
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127144 - fee1-dead-contrib:newfx2, r=<try>
0c92609 
Make `has_attr` check behind effects feature

attempt to fix the performance regression in rust-lang#120639.

cc rust-lang#110395

r? project-const-traits
@bors
Copy link
Contributor

bors commented Jun 30, 2024

⌛ Trying commit a1157c7 with merge 0c92609...

compiler-errors
compiler-errors approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if perf is improved 💀

has_attr calls are notorious for causing problems with perf -- we could perhaps whether a trait is const to the TraitDef

@fee1-dead fee1-dead mentioned this pull request Jun 30, 2024
Merged
4 tasks
@fee1-dead
Copy link
Member Author

we could perhaps whether a trait is const to the TraitDef

good as a followup. Will do when I get time

@compiler-errors
Copy link
Member

thanks lmao i realized i forgot a verb in that sentence -- "record" whether

@bors
Copy link
Contributor

bors commented Jun 30, 2024

☀️ Try build successful - checks-actions
Build commit: 0c92609 (0c92609f7b1146673c3f0abd4d21faa6a5539dd8)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0c92609): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 696.374s -> 697.881s (0.22%)
Artifact size: 324.63 MiB -> 324.61 MiB (-0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 30, 2024
camelid added a commit to camelid/rust that referenced this pull request Jun 30, 2024
@camelid
Queryify has_attr to improve performance
a75363e 
Inspired by rust-lang#127144 (review)
and previous success in rust-lang#94897.
@camelid camelid mentioned this pull request Jun 30, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@bors
Auto merge of rust-lang#127185 - camelid:query-has_attr, r=<try>
53af5a5 
Queryify `has_attr` to improve performance

Inspired by rust-lang#127144 (review)
and previous success in rust-lang#94897.

r? `@compiler-errors`
@fee1-dead fee1-dead closed this Jul 1, 2024
@fee1-dead fee1-dead deleted the newfx2 branch July 1, 2024 07:14
@fmease fmease removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@fmease fmease

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fee1-dead @rust-timer @bors @compiler-errors @fmease @rustbot