rustdoc: Remove OpaqueTy #127276

aDotInTheVoid · 2024-07-03T14:38:45Z

Apparently this works lol?!?

try-job: aarch64-apple

GuillaumeGomez

I love when code can just be removed. :)

fmease · 2024-07-03T17:49:27Z

Good catch! Youp, it's fine since we don't care about the internal opaque items, we just care about the opaque types.

aDotInTheVoid · 2024-07-03T20:30:48Z

src/rustdoc-json-types/lib.rs

@@ -8,7 +8,7 @@ use serde::{Deserialize, Serialize};
 use std::path::PathBuf;

 /// rustdoc format-version.
-pub const FORMAT_VERSION: u32 = 30;
+pub const FORMAT_VERSION: u32 = 31;


This shouldn't me merged until after #127289, as they both bump the version

aDotInTheVoid · 2024-07-03T20:32:21Z

src/librustdoc/formats/item_type.rs

@@ -52,7 +52,7 @@ pub(crate) enum ItemType {
    AssocConst = 19,
    Union = 20,
    ForeignType = 21,
-    OpaqueTy = 22,
+    // OpaqueTy used to be here, but it was removed in #127276


CC @notriddle, as this is part of the rustdoc-the-binary<->rustdoc-search boundry

Should be fine. The "existential" names aren't doing anything, and can probably be replaced with empty strings.

rust/src/librustdoc/html/static/js/search.js

Lines 19 to 78 in 2b90614

// This mapping table should match the discriminants of

// `rustdoc::formats::item_type::ItemType` type in Rust.

const itemTypes = [

"keyword",

"primitive",

"mod",

"externcrate",

"import",

"struct", // 5

"enum",

"fn",

"type",

"static",

"trait", // 10

"impl",

"tymethod",

"method",

"structfield",

"variant", // 15

"macro",

"associatedtype",

"constant",

"associatedconstant",

"union", // 20

"foreigntype",

"existential",

"attr",

"derive",

"traitalias", // 25

"generic",

];

const longItemTypes = [

"keyword",

"primitive type",

"module",

"extern crate",

"re-export",

"struct",

"enum",

"function",

"type alias",

"static",

"trait",

"",

"trait method",

"method",

"struct field",

"enum variant",

"macro",

"assoc type",

"constant",

"assoc const",

"union",

"foreign type",

"existential type",

"attribute macro",

"derive macro",

"trait alias",

];

rustbot · 2024-07-03T20:32:55Z

Some changes occurred in src/librustdoc/clean/types.rs

cc @camelid

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

aDotInTheVoid · 2024-07-03T20:33:33Z

r? @camelid

camelid · 2024-07-07T21:33:29Z

Awesome find, thanks!

@bors r+ rollup

bors · 2024-07-07T21:33:32Z

📌 Commit 7c76747 has been approved by camelid

It is now in the queue for this repository.

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!?

Rollup of 12 pull requests Successful merges: - rust-lang#113128 (Support tail calls in mir via `TerminatorKind::TailCall`) - rust-lang#126841 ([`macro_metavar_expr_concat`] Add support for literals) - rust-lang#126881 (Make `NEVER_TYPE_FALLBACK_FLOWING_INTO_UNSAFE` a deny-by-default lint in edition 2024) - rust-lang#126921 (Give VaList its own home) - rust-lang#127276 (rustdoc: Remove OpaqueTy) - rust-lang#127367 (Run alloc sync tests) - rust-lang#127431 (Use field ident spans directly instead of the full field span in diagnostics on local fields) - rust-lang#127437 (Uplift trait ref is knowable into `rustc_next_trait_solver`) - rust-lang#127439 (Uplift elaboration into `rustc_type_ir`) - rust-lang#127451 (Improve `run-make/output-type-permutations` code and improve `filename_not_in_denylist` API) - rust-lang#127452 (Fix intrinsic const parameter counting with `effects`) - rust-lang#127459 (rustdoc-json: add type/trait alias tests) r? `@ghost` `@rustbot` modify labels: rollup

jieyouxu · 2024-07-08T05:03:48Z

This PR looks suspicious to me as the cause of failure in #127475 (comment). Feel free to re-approve if this PR is not the cause.

@bors r-

jieyouxu · 2024-07-08T05:04:05Z

@bors try

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

bors · 2024-07-08T05:05:15Z

⌛ Trying commit 7c76747 with merge 00552c6...

jieyouxu · 2024-07-08T05:07:17Z

ICE message

2024-07-08T04:32:52.1458770Z thread 'rustc' panicked at src/librustdoc/clean/mod.rs:2819:18:
2024-07-08T04:32:52.1560090Z internal error: entered unreachable code: not yet converted
2024-07-08T04:32:52.1663130Z stack backtrace:
2024-07-08T04:32:52.1742000Z    0:        0x10603eac0 - <std::sys::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h03c274328d9923fb
2024-07-08T04:32:52.1745950Z    1:        0x106081d54 - core::fmt::write::hfc23d7de2930d59b
2024-07-08T04:32:52.1809130Z    2:        0x1060349fc - std::io::Write::write_fmt::h8ff76bf83f9ff955
2024-07-08T04:32:52.1872480Z    3:        0x10603e918 - std::sys::backtrace::print::hb7f4775d7ed1e12e
2024-07-08T04:32:52.1892800Z    4:        0x106040f28 - std::panicking::default_hook::{{closure}}::h33f7b74c09dbaa9d
2024-07-08T04:32:52.1899670Z    5:        0x106040bf4 - std::panicking::default_hook::hdd08ba5aa598c81b
2024-07-08T04:32:52.1904960Z    6:        0x10f1b0690 - <alloc[1e9c988f37cf81b2]::boxed::Box<rustc_driver_impl[a7993e430336e74c]::install_ice_hook::{closure#0}> as core[cc103daf103e831a]::ops::function::Fn<(&dyn for<'a, 'b> core[cc103daf103e831a]::ops::function::Fn<(&'a std[b7d054e4fd31b525]::panic::PanicHookInfo<'b>,), Output = ()> + core[cc103daf103e831a]::marker::Sync + core[cc103daf103e831a]::marker::Send, &std[b7d054e4fd31b525]::panic::PanicHookInfo)>>::call
2024-07-08T04:32:52.1979680Z    7:        0x106041ab8 - std::panicking::rust_panic_with_hook::hcdca9952db3e7a6c
2024-07-08T04:32:52.1980790Z    8:        0x1060413a0 - std::panicking::begin_panic_handler::{{closure}}::h7530693faefe330d
2024-07-08T04:32:52.1981750Z    9:        0x10603ef4c - std::sys::backtrace::__rust_end_short_backtrace::h5d8a6c5af936bc6d
2024-07-08T04:32:52.1996180Z   10:        0x106041090 - _rust_begin_unwind
2024-07-08T04:32:52.2054110Z   11:        0x10609c66c - core::panicking::panic_fmt::hf4041e2666da7a59
2024-07-08T04:32:52.2055530Z   12:        0x10467a434 - <rustdoc[6e5addee39934cb1]::core::DocContext>::with_param_env::<alloc[1e9c988f37cf81b2]::vec::Vec<rustdoc[6e5addee39934cb1]::clean::types::Item>, rustdoc[6e5addee39934cb1]::clean::clean_maybe_renamed_item::{closure#1}>
2024-07-08T04:32:52.2057830Z   13:        0x10482a88c - <&mut rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#2} as core[cc103daf103e831a]::ops::function::FnOnce<(&(&rustc_hir[faf7167ecb130f2c]::hir::Item, core[cc103daf103e831a]::option::Option<rustc_span[fb1ade04d581d706]::symbol::Symbol>, core[cc103daf103e831a]::option::Option<rustc_span[fb1ade04d581d706]::def_id::LocalDefId>),)>>::call_once
2024-07-08T04:32:52.2062520Z   14:        0x1046d82cc - <alloc[1e9c988f37cf81b2]::vec::Vec<rustdoc[6e5addee39934cb1]::clean::types::Item> as alloc[1e9c988f37cf81b2]::vec::spec_extend::SpecExtend<rustdoc[6e5addee39934cb1]::clean::types::Item, core[cc103daf103e831a]::iter::adapters::flatten::FlatMap<indexmap[e87678ff1e8617bb]::map::iter::Values<(rustc_span[fb1ade04d581d706]::def_id::LocalDefId, core[cc103daf103e831a]::option::Option<rustc_span[fb1ade04d581d706]::symbol::Symbol>), (&rustc_hir[faf7167ecb130f2c]::hir::Item, core[cc103daf103e831a]::option::Option<rustc_span[fb1ade04d581d706]::symbol::Symbol>, core[cc103daf103e831a]::option::Option<rustc_span[fb1ade04d581d706]::def_id::LocalDefId>)>, alloc[1e9c988f37cf81b2]::vec::Vec<rustdoc[6e5addee39934cb1]::clean::types::Item>, rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#2}>>>::spec_extend
2024-07-08T04:32:52.2065860Z   15:        0x10483ba18 - rustdoc[6e5addee39934cb1]::clean::clean_doc_module
2024-07-08T04:32:52.2067110Z   16:        0x10482931c - <&mut rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#1} as core[cc103daf103e831a]::ops::function::FnMut<(&rustdoc[6e5addee39934cb1]::visit_ast::Module,)>>::call_mut
2024-07-08T04:32:52.2069470Z   17:        0x1046d7990 - <alloc[1e9c988f37cf81b2]::vec::Vec<rustdoc[6e5addee39934cb1]::clean::types::Item> as alloc[1e9c988f37cf81b2]::vec::spec_extend::SpecExtend<rustdoc[6e5addee39934cb1]::clean::types::Item, core[cc103daf103e831a]::iter::adapters::filter_map::FilterMap<core[cc103daf103e831a]::slice::iter::Iter<rustdoc[6e5addee39934cb1]::visit_ast::Module>, rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#1}>>>::spec_extend
2024-07-08T04:32:52.2071300Z   18:        0x10483b9f0 - rustdoc[6e5addee39934cb1]::clean::clean_doc_module
2024-07-08T04:32:52.2072420Z   19:        0x10482931c - <&mut rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#1} as core[cc103daf103e831a]::ops::function::FnMut<(&rustdoc[6e5addee39934cb1]::visit_ast::Module,)>>::call_mut
2024-07-08T04:32:52.2074910Z   20:        0x1046d7990 - <alloc[1e9c988f37cf81b2]::vec::Vec<rustdoc[6e5addee39934cb1]::clean::types::Item> as alloc[1e9c988f37cf81b2]::vec::spec_extend::SpecExtend<rustdoc[6e5addee39934cb1]::clean::types::Item, core[cc103daf103e831a]::iter::adapters::filter_map::FilterMap<core[cc103daf103e831a]::slice::iter::Iter<rustdoc[6e5addee39934cb1]::visit_ast::Module>, rustdoc[6e5addee39934cb1]::clean::clean_doc_module::{closure#1}>>>::spec_extend
2024-07-08T04:32:52.2076760Z   21:        0x10483b9f0 - rustdoc[6e5addee39934cb1]::clean::clean_doc_module
2024-07-08T04:32:52.2077460Z   22:        0x10495f294 - rustdoc[6e5addee39934cb1]::clean::utils::krate
2024-07-08T04:32:52.2078540Z   23:        0x10480d0d4 - <rustc_session[35e24ab0d5bb60b]::session::Session>::time::<rustdoc[6e5addee39934cb1]::clean::types::Crate, rustdoc[6e5addee39934cb1]::core::run_global_ctxt::{closure#4}>
2024-07-08T04:32:52.2079600Z   24:        0x10467d900 - rustdoc[6e5addee39934cb1]::core::run_global_ctxt
2024-07-08T04:32:52.2080880Z   25:        0x10480f72c - <rustc_middle[71274973e736d054]::ty::context::GlobalCtxt>::enter::<rustdoc[6e5addee39934cb1]::main_args::{closure#1}::{closure#0}::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>
2024-07-08T04:32:52.2082720Z   26:        0x1047fdec8 - rustc_interface[8e82f8070106c52]::interface::run_compiler::<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustdoc[6e5addee39934cb1]::main_args::{closure#1}>::{closure#1}
2024-07-08T04:32:52.2086490Z   27:        0x1047c4b38 - <scoped_tls[5925241c2ed4484d]::ScopedKey<rustc_span[fb1ade04d581d706]::SessionGlobals>>::set::<rustc_interface[8e82f8070106c52]::util::run_in_thread_with_globals<rustc_interface[8e82f8070106c52]::util::run_in_thread_pool_with_globals<rustc_interface[8e82f8070106c52]::interface::run_compiler<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustdoc[6e5addee39934cb1]::main_args::{closure#1}>::{closure#1}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>
2024-07-08T04:32:52.2091970Z   28:        0x104898244 - rustc_span[fb1ade04d581d706]::create_session_globals_then::<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustc_interface[8e82f8070106c52]::util::run_in_thread_with_globals<rustc_interface[8e82f8070106c52]::util::run_in_thread_pool_with_globals<rustc_interface[8e82f8070106c52]::interface::run_compiler<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustdoc[6e5addee39934cb1]::main_args::{closure#1}>::{closure#1}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}::{closure#0}::{closure#0}>
2024-07-08T04:32:52.2097230Z   29:        0x1047f7c58 - std[b7d054e4fd31b525]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[8e82f8070106c52]::util::run_in_thread_with_globals<rustc_interface[8e82f8070106c52]::util::run_in_thread_pool_with_globals<rustc_interface[8e82f8070106c52]::interface::run_compiler<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustdoc[6e5addee39934cb1]::main_args::{closure#1}>::{closure#1}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>
2024-07-08T04:32:52.2102910Z   30:        0x10466f0e8 - <<std[b7d054e4fd31b525]::thread::Builder>::spawn_unchecked_<rustc_interface[8e82f8070106c52]::util::run_in_thread_with_globals<rustc_interface[8e82f8070106c52]::util::run_in_thread_pool_with_globals<rustc_interface[8e82f8070106c52]::interface::run_compiler<core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>, rustdoc[6e5addee39934cb1]::main_args::{closure#1}>::{closure#1}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#0}::{closure#0}, core[cc103daf103e831a]::result::Result<(), rustc_span[fb1ade04d581d706]::ErrorGuaranteed>>::{closure#2} as core[cc103daf103e831a]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0}
2024-07-08T04:32:52.2106870Z   31:        0x10604a004 - std::sys::pal::unix::thread::Thread::new::thread_start::habdd2bc86a98b64c
2024-07-08T04:32:52.2107520Z   32:        0x1854bef94 - __pthread_joiner_wake
2024-07-08T04:32:52.2107920Z 
2024-07-08T04:32:52.2109420Z error: the compiler unexpectedly panicked. this is a bug.
2024-07-08T04:32:52.2117200Z 
2024-07-08T04:32:52.2118360Z note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-rustdoc&template=ice.md
2024-07-08T04:32:52.2119160Z 
2024-07-08T04:32:52.2119550Z note: please make sure that you have updated to the latest nightly
2024-07-08T04:32:52.2119990Z 
2024-07-08T04:32:52.2120650Z note: please attach the file at `/Users/runner/work/rust/rust/rustc-ice-2024-07-08T04_32_52-20708.txt` to your bug report
2024-07-08T04:32:52.2121340Z 
2024-07-08T04:32:52.2122550Z note: compiler flags: --crate-type lib -Z unstable-options -C symbol-mangling-version=v0 -Z unstable-options -Z unstable-options -Z normalize-docs -Z crate-attr=warn(rust_2018_idioms) -Z force-unstable-if-unmarked -Z unstable-options
2024-07-08T04:32:52.2123700Z 
2024-07-08T04:32:52.2124010Z note: some of the compiler flags provided by cargo are hidden
2024-07-08T04:32:52.2124480Z 
2024-07-08T04:32:52.2124670Z query stack during panic:
2024-07-08T04:32:52.2125090Z end of query stack
2024-07-08T04:32:52.2125940Z �[1m�[31merror�[0m�[1m:�[0m could not document `rustc_mir_transform`
2024-07-08T04:32:52.2126700Z �[1m�[33mwarning�[0m�[1m:�[0m build failed, waiting for other jobs to finish...

camelid

Thanks again!

camelid · 2024-07-31T05:15:01Z

r=me with conflicts fixed

aDotInTheVoid · 2024-08-01T16:00:12Z

@bors try

bors · 2024-08-01T16:01:23Z

⌛ Trying commit 73ac5e0 with merge 2bd25c7...

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

bors · 2024-08-01T17:13:56Z

☀️ Try build successful - checks-actions
Build commit: 2bd25c7 (2bd25c72d85e5733d6c53fc1f98e429cd0fc9ca0)

aDotInTheVoid · 2024-08-01T17:16:57Z

@bors r=camelid

bors · 2024-08-01T17:16:59Z

📌 Commit 73ac5e0 has been approved by camelid

It is now in the queue for this repository.

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

Rollup of 5 pull requests Successful merges: - rust-lang#127276 (rustdoc: Remove OpaqueTy) - rust-lang#128404 (Revert recent changes to dead code analysis) - rust-lang#128466 (Update the stdarch submodule) - rust-lang#128483 (Still more `cfg` cleanups) - rust-lang#128494 (MIR required_consts, mentioned_items: ensure we do not forget to fill these lists) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-08-01T19:45:28Z

⌛ Testing commit 73ac5e0 with merge 8e86c95...

bors · 2024-08-01T22:11:18Z

☀️ Test successful - checks-actions
Approved by: camelid
Pushing 8e86c95 to master...

…melid rustdoc: Remove dead opaque_tys rendering logic rust-lang#127276 removed OpaqueTy from clean, and the code populating AllTypes::opaque_tys, but not this field itself.

Rollup merge of rust-lang#128521 - aDotInTheVoid:opaque-fallout, r=camelid rustdoc: Remove dead opaque_tys rendering logic rust-lang#127276 removed OpaqueTy from clean, and the code populating AllTypes::opaque_tys, but not this field itself.

rust-timer · 2024-08-02T08:37:45Z

Finished benchmarking commit (8e86c95): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary 2.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 759.172s -> 758.235s (-0.12%)
Artifact size: 336.79 MiB -> 336.83 MiB (0.01%)

rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jul 3, 2024

GuillaumeGomez approved these changes Jul 3, 2024

View reviewed changes

aDotInTheVoid mentioned this pull request Jul 3, 2024

rustdoc-json: Guard agains 2 commits making the same modification to FORMAT_VERSION #94591

Open

rust-cloud-vms bot force-pushed the no-opaque branch 2 times, most recently from b20368b to 024fd76 Compare July 3, 2024 20:29

aDotInTheVoid commented Jul 3, 2024

View reviewed changes

aDotInTheVoid marked this pull request as ready for review July 3, 2024 20:32

rustbot assigned camelid Jul 3, 2024

rust-cloud-vms bot force-pushed the no-opaque branch 2 times, most recently from 8e21be7 to 7c76747 Compare July 4, 2024 13:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2024

jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jul 8, 2024

Rollup merge of rust-lang#127276 - aDotInTheVoid:no-opaque, r=camelid

6f753c8

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!?

jieyouxu mentioned this pull request Jul 8, 2024

Rollup of 12 pull requests #127475

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 8, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 8, 2024

Auto merge of rust-lang#127276 - aDotInTheVoid:no-opaque, r=<try>

00552c6

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

camelid approved these changes Jul 31, 2024

View reviewed changes

camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2024

rust-cloud-vms bot force-pushed the no-opaque branch from f29bc7a to 408b70b Compare August 1, 2024 15:43

aDotInTheVoid added 2 commits August 1, 2024 15:48

rustdoc: Add test for impl_trait_in_accos_type

52a49d9

rustdoc: Remove OpaqueTy

73ac5e0

rust-cloud-vms bot force-pushed the no-opaque branch from 408b70b to 73ac5e0 Compare August 1, 2024 15:59

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 1, 2024

Auto merge of rust-lang#127276 - aDotInTheVoid:no-opaque, r=<try>

2bd25c7

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2024

tgross35 added a commit to tgross35/rust that referenced this pull request Aug 1, 2024

Rollup merge of rust-lang#127276 - aDotInTheVoid:no-opaque, r=camelid

44ccae1

rustdoc: Remove OpaqueTy r? `@ghost` Apparently this works lol?!? try-job: aarch64-apple

tgross35 mentioned this pull request Aug 1, 2024

Rollup of 5 pull requests #128508

Closed

bors mentioned this pull request Aug 1, 2024

Migrate and rename issue-47551, issue-35164 and issue-69368 run-make tests to rmake #127624

Merged

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 1, 2024

bors merged commit 8e86c95 into rust-lang:master Aug 1, 2024
7 checks passed

rustbot added this to the 1.82.0 milestone Aug 1, 2024

aDotInTheVoid mentioned this pull request Aug 1, 2024

rustdoc: Remove dead opaque_tys rendering logic #128521

Merged

aDotInTheVoid mentioned this pull request Aug 15, 2024

Rustdoc-Json: More inconsistant names #100961

Open

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rustdoc: Remove OpaqueTy #127276

rustdoc: Remove OpaqueTy #127276

aDotInTheVoid commented Jul 3, 2024 •

edited by jieyouxu

Loading

GuillaumeGomez left a comment

fmease commented Jul 3, 2024

aDotInTheVoid Jul 3, 2024

aDotInTheVoid Jul 3, 2024

notriddle Jul 3, 2024

rustbot commented Jul 3, 2024

aDotInTheVoid commented Jul 3, 2024

camelid commented Jul 7, 2024

bors commented Jul 7, 2024

jieyouxu commented Jul 8, 2024

jieyouxu commented Jul 8, 2024

bors commented Jul 8, 2024

jieyouxu commented Jul 8, 2024

camelid left a comment

camelid commented Jul 31, 2024

aDotInTheVoid commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

aDotInTheVoid commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

rust-timer commented Aug 2, 2024

	// This mapping table should match the discriminants of
	// `rustdoc::formats::item_type::ItemType` type in Rust.
	const itemTypes = [
	"keyword",
	"primitive",
	"mod",
	"externcrate",
	"import",
	"struct", // 5
	"enum",
	"fn",
	"type",
	"static",
	"trait", // 10
	"impl",
	"tymethod",
	"method",
	"structfield",
	"variant", // 15
	"macro",
	"associatedtype",
	"constant",
	"associatedconstant",
	"union", // 20
	"foreigntype",
	"existential",
	"attr",
	"derive",
	"traitalias", // 25
	"generic",
	];

	const longItemTypes = [
	"keyword",
	"primitive type",
	"module",
	"extern crate",
	"re-export",
	"struct",
	"enum",
	"function",
	"type alias",
	"static",
	"trait",
	"",
	"trait method",
	"method",
	"struct field",
	"enum variant",
	"macro",
	"assoc type",
	"constant",
	"assoc const",
	"union",
	"foreign type",
	"existential type",
	"attribute macro",
	"derive macro",
	"trait alias",
	];

rustdoc: Remove OpaqueTy #127276

rustdoc: Remove OpaqueTy #127276

Conversation

aDotInTheVoid commented Jul 3, 2024 • edited by jieyouxu Loading

GuillaumeGomez left a comment

Choose a reason for hiding this comment

fmease commented Jul 3, 2024

aDotInTheVoid Jul 3, 2024

Choose a reason for hiding this comment

aDotInTheVoid Jul 3, 2024

Choose a reason for hiding this comment

notriddle Jul 3, 2024

Choose a reason for hiding this comment

rustbot commented Jul 3, 2024

aDotInTheVoid commented Jul 3, 2024

camelid commented Jul 7, 2024

bors commented Jul 7, 2024

jieyouxu commented Jul 8, 2024

jieyouxu commented Jul 8, 2024

bors commented Jul 8, 2024

jieyouxu commented Jul 8, 2024

camelid left a comment

Choose a reason for hiding this comment

camelid commented Jul 31, 2024

aDotInTheVoid commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

aDotInTheVoid commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

bors commented Aug 1, 2024

rust-timer commented Aug 2, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

aDotInTheVoid commented Jul 3, 2024 •

edited by jieyouxu

Loading