Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve run make llvm ident code #127359

Merged

Conversation

GuillaumeGomez
Copy link
Member

I took the commits that are not blocking #127237.

r? @Kobzol

@rustbot
Copy link
Collaborator

rustbot commented Jul 5, 2024

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

The run-make-support library was changed

cc @jieyouxu

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Jul 5, 2024

Thanks!
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 5, 2024

📌 Commit 415e202 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 5, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2024
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#124290 (DependencyList: removed outdated comment)
 - rust-lang#126709 (Migrate `include_bytes_deps`, `optimization-remarks-dir-pgo`, `optimization-remarks-dir`, `issue-40535` and `rmeta-preferred` `run-make` tests to rmake)
 - rust-lang#127214 (Use the native unwind function in miri where possible)
 - rust-lang#127320 (Update windows-bindgen to 0.58.0)
 - rust-lang#127349 (Tweak `-1 as usize` suggestion)
 - rust-lang#127352 (coverage: Rename `mir::coverage::BranchInfo` to `CoverageInfoHi`)
 - rust-lang#127359 (Improve run make llvm ident code)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4fd3b12 into rust-lang:master Jul 5, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 5, 2024
Rollup merge of rust-lang#127359 - GuillaumeGomez:improve-run-make-llvm-ident-code, r=jieyouxu

Improve run make llvm ident code

I took the commits that are not blocking rust-lang#127237.

r? `@Kobzol`
@rustbot rustbot added this to the 1.81.0 milestone Jul 5, 2024
@GuillaumeGomez GuillaumeGomez deleted the improve-run-make-llvm-ident-code branch July 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants