-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #127876
Rollup of 9 pull requests #127876
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f305ff - Browse repository at this point
Copy the full SHA 2f305ffView commit details -
Inline
Parser::parse_item_common_
.It has a single call site, it isn't that big, and its name is confusingly similar to `Parser::parse_item_common`.
Configuration menu - View commit details
-
Copy full SHA for 48cdfc3 - Browse repository at this point
Copy the full SHA 48cdfc3View commit details -
Reorder
Parser::parse_expr_dot_or_call_with
arguments.Put `attrs` before `e0` because that matches the order in the source code, where outer attributes appear before expressions.
Configuration menu - View commit details
-
Copy full SHA for d247489 - Browse repository at this point
Copy the full SHA d247489View commit details -
Inline and remove
Parser::parse_and_disallow_postfix_after_cast
.It has a single call site. Removing it removes the need for an `ExprKind` check. The commit also clarifies the relevant comment.
Configuration menu - View commit details
-
Copy full SHA for 96cc9c9 - Browse repository at this point
Copy the full SHA 96cc9c9View commit details -
Inline and remove
Parser::parse_expr_dot_or_call_with_
.It only has two call sites, and it extremely similar to `Parser::parse_expr_dot_or_call_with`, in both name and behaviour. The only difference is the latter has an `attrs` argument and an `ensure_sufficient_stack` call. We can pass in an empty `attrs` as necessary, as is already done at some `parse_expr_dot_or_call_with` call sites.
Configuration menu - View commit details
-
Copy full SHA for 96b39f1 - Browse repository at this point
Copy the full SHA 96b39f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cb6bc3 - Browse repository at this point
Copy the full SHA 8cb6bc3View commit details -
Remove references to
maybe_whole_expr
.It was removed in rust-lang#126571.
Configuration menu - View commit details
-
Copy full SHA for 9c4f3db - Browse repository at this point
Copy the full SHA 9c4f3dbView commit details
Commits on Jul 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 17c70a9 - Browse repository at this point
Copy the full SHA 17c70a9View commit details -
unix: stack_start_aligned is a safe fn
This function is purely informative, answering where a stack starts. This is a safe operation, even if an answer requires unsafe code, and even if the result is some unsafe code decides to trust the answer. It also doesn't need to fetch the PAGE_SIZE when its caller just did so! Let's complicate its signature and in doing so simplify its operation. This allows sprinkling around #[forbid(unsafe_op_in_unsafe_fn)]
Configuration menu - View commit details
-
Copy full SHA for e285c95 - Browse repository at this point
Copy the full SHA e285c95View commit details -
unix: clean up install_main_guard_freebsd
This just was a mess.
Configuration menu - View commit details
-
Copy full SHA for 6ed563d - Browse repository at this point
Copy the full SHA 6ed563dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d47cb26 - Browse repository at this point
Copy the full SHA d47cb26View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc48b0 - Browse repository at this point
Copy the full SHA adc48b0View commit details -
Document the column numbers for the dbg! macro
The line numbers were also made consistent, some examples used the line numbers as shown on the playground while others used the line numbers that you would expect when just seeing the documentation. The second option was chosen to make everything consistent.
Configuration menu - View commit details
-
Copy full SHA for 99f879c - Browse repository at this point
Copy the full SHA 99f879cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d40d4c - Browse repository at this point
Copy the full SHA 1d40d4cView commit details -
Commonize
uname -m
results foraarch64
in docker runner`uname -m` on Linux reports `aarch64`, but on MacOS reports `arm64`. Commonize this to `aarch64`. With this fix, it is now possible to run aarch64 CI docker images on Arm MacOS.
Configuration menu - View commit details
-
Copy full SHA for f3f0b57 - Browse repository at this point
Copy the full SHA f3f0b57View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1852d0 - Browse repository at this point
Copy the full SHA e1852d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 261d92c - Browse repository at this point
Copy the full SHA 261d92cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 12bedc3 - Browse repository at this point
Copy the full SHA 12bedc3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 213782d - Browse repository at this point
Copy the full SHA 213782dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 553279b - Browse repository at this point
Copy the full SHA 553279bView commit details -
style-guide: Clarify version-sorting
Every time we apply version-sorting, we also say to sort non-lowercase before lowercase. This seems likely to be what we'll want for future sorting, as well. For simplicity, just incorporate that into the definition, "unless otherwise specified".
Configuration menu - View commit details
-
Copy full SHA for 37257b4 - Browse repository at this point
Copy the full SHA 37257b4View commit details -
Rollup merge of rust-lang#127542 - c410-f3r:concat-again, r=petrochenkov
[`macro_metavar_expr_concat`] Add support for literals Adds support for literals in macro parameters. ```rust macro_rules! with_literal { ($literal:literal) => { const ${concat(FOO, $literal)}: i32 = 1; } } fn main() { with_literal!("_BAR"); assert_eq!(FOO_BAR, 1); } ``` cc rust-lang#124225 r? `@petrochenkov`
Configuration menu - View commit details
-
Copy full SHA for 2b60845 - Browse repository at this point
Copy the full SHA 2b60845View commit details -
Rollup merge of rust-lang#127652 - GuillaumeGomez:cg-gcc-fmt, r=Urgau
Unignore cg_gcc fmt `rustc_codegen_gcc` uses `rustfmt` now so it can be unignored. r? `@Urgau`
Configuration menu - View commit details
-
Copy full SHA for 51caf9c - Browse repository at this point
Copy the full SHA 51caf9cView commit details -
Rollup merge of rust-lang#127664 - compiler-errors:precise-capturing-…
…better-sugg-apit, r=oli-obk Fix precise capturing suggestion for hidden regions when we have APITs Suggests to turn APITs into type parameters so they can be named in precise capturing syntax for hidden type lifetime errors. We also note that it may change the API. This is currently done via a note *and* a suggestion, which feels a bit redundant, but I wasn't totally sure of a better alternative for the presentation. Code is kind of a mess but there's a lot of cases to consider. Happy to iterate on this if you think the approach is too messy. Based on rust-lang#127619, only the last commit is relevant. r? oli-obk Tracking: - rust-lang#123432
Configuration menu - View commit details
-
Copy full SHA for 52fffe9 - Browse repository at this point
Copy the full SHA 52fffe9View commit details -
Rollup merge of rust-lang#127806 - nnethercote:parser-improvements, r…
…=spastorino Some parser improvements I was looking closely at attribute handling in the parser while debugging some issues relating to rust-lang#124141, and found a few small improvements. `@spastorino`
Configuration menu - View commit details
-
Copy full SHA for a560a59 - Browse repository at this point
Copy the full SHA a560a59View commit details -
Rollup merge of rust-lang#127828 - tgross35:docker-aarch64-uname, r=o…
…nur-ozkan Commonize `uname -m` results for `aarch64` in docker runner `uname -m` on Linux reports `aarch64`, but on MacOS reports `arm64`. Commonize this to `aarch64`. With this fix, it is now possible to run aarch64 CI docker images on Arm MacOS.
Configuration menu - View commit details
-
Copy full SHA for 909309b - Browse repository at this point
Copy the full SHA 909309bView commit details -
Rollup merge of rust-lang#127845 - workingjubilee:actually-break-up-b…
…ig-ass-stack-overflow-fn, r=joboet unix: break `stack_overflow::install_main_guard` into smaller fn This was one big deeply-indented function for no reason. This made it hard to reason about the boundaries of its safety. Or just, y'know, read. Simplify it by splitting it into platform-specific functions, but which are still asked to keep compiling (a desirable property, since all of these OS use a similar API). This is mostly a whitespace change, so I suggest reviewing it only after setting Files changed -> (the options gear) -> [x] Hide whitespace as that will make it easier to see how the code was actually broken up instead of raw line diffs.
Configuration menu - View commit details
-
Copy full SHA for aaa1041 - Browse repository at this point
Copy the full SHA aaa1041View commit details -
Rollup merge of rust-lang#127854 - fmease:glob-import-type_ir_inheren…
…t-lint, r=compiler-errors Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent` rust-lang#127627 (comment) r? compiler-errors
Configuration menu - View commit details
-
Copy full SHA for 831a039 - Browse repository at this point
Copy the full SHA 831a039View commit details -
Rollup merge of rust-lang#127861 - Kriskras99:patch-1, r=tgross35
Document the column numbers for the dbg! macro The line numbers were also made consistent, some examples used the line numbers as shown on the playground while others used the line numbers that you would expect when just seeing the documentation. The second option was chosen to make everything consistent.
Configuration menu - View commit details
-
Copy full SHA for 9f7c8d1 - Browse repository at this point
Copy the full SHA 9f7c8d1View commit details -
Rollup merge of rust-lang#127875 - joshtriplett:style-guide-clarify-s…
…orting, r=compiler-errors style-guide: Clarify version-sorting Every time we apply version-sorting, we also say to sort non-lowercase before lowercase. This seems likely to be what we'll want for future sorting, as well. For simplicity, just incorporate that into the definition, "unless otherwise specified".
Configuration menu - View commit details
-
Copy full SHA for 5a8d0ec - Browse repository at this point
Copy the full SHA 5a8d0ecView commit details