Update extern linking documentation #127908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, remove the note saying cdylibs can't link against dylibs — that hasn't been true for over four years. * 2019-11-07: note is written: rust-lang@b54e8ec * 2020-01-23: restriction is lifted (without updating docs): rust-lang@72aaa3a
|
rustbot has assigned @GuillaumeGomez. Use |
rustbot
added
the
S-waiting-on-review
|
Looks good to me but let's set someone from the compiler team as reviewer. r? compiler |
rustbot
added
the
T-compiler
|
r? jieyouxu |
jieyouxu
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thank you for the correction, this looks to be accurate as we do have a test for it: https://github.com/rust-lang/rust/blob/b01a977b0737e177f9b03949b908c250020d0119/tests/run-make/cdylib-dylib-linkage/Makefile (shuffled around from src/test/run-make-fulldeps/cdylib-dylib-linkage/Makefile introduced by the original commit that lifted this restriction).
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124881 (Use ThreadId instead of TLS-address in `ReentrantLock`) - rust-lang#127656 (make pub_use_of_private_extern_crate show up in cargo's future breakage reports) - rust-lang#127748 (Use Option's discriminant as its size hint) - rust-lang#127854 (Add internal lint for detecting non-glob imports of `rustc_type_ir::inherent`) - rust-lang#127908 (Update extern linking documentation) - rust-lang#127919 (Allow a git command for getting the current branch in bootstrap to fail) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2024
Rollup merge of rust-lang#127908 - fasterthanlime:patch-1, r=jieyouxu Update extern linking documentation In particular, remove the note saying cdylibs can't link against dylibs — that hasn't been true for over four years. * 2019-11-07: note is written: rust-lang@b54e8ec * 2020-01-23: restriction is lifted (without updating docs): rust-lang@72aaa3a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, remove the note saying cdylibs can't link against dylibs — that hasn't been true for over four years.