Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change binary_asm_labels to only fire on x86 and x86_64 #127935

Merged
merged 3 commits into from
Jul 19, 2024

Commits on Jul 18, 2024

  1. Change binary_asm_labels to only fire on x86 and x86_64

    In <rust-lang#126922>, the
    `binary_asm_labels` lint was added which flags labels such as `0:` and
    `1:`. Before that change, LLVM was giving a confusing error on
    x86/x86_64 because of an incorrect interpretation.
    
    However, targets other than x86 and x86_64 never had the error message
    and have not been a problem. This means that the lint was causing code
    that previously worked to start failing (e.g. `compiler_builtins`),
    rather than only providing a more clear messages where there has always
    been an error.
    
    Adjust the lint to only fire on x86 and x86_64 assembly to avoid this
    regression.
    tgross35 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9387a75 View commit details
    Browse the repository at this point in the history
  2. Update the binary_asm_label message

    The link pointed to a closed issue. Create a new one and point the link
    to it.
    
    Also add a help message to hint what change the user could make.
    
    Fixes: rust-lang#127821
    tgross35 committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    8410348 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Update the binary_asm_label documentation

    Disable a test that now only passes on x86 and make the link point to
    the new (open) LLVM bug.
    tgross35 committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5686720 View commit details
    Browse the repository at this point in the history