Re-enable more debuginfo tests on freebsd #128990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…<try> Re-enable debuginfo tests on freebsd r? `@ghost` try-job: dist-various-2 try-job: dist-x86_64-freebsd
|
☀️ Try build successful - checks-actions |
|
Same here, these two runners don't actually run any tests. In fact I don't think that we even run any tests for FreeBSD, as it's not a tier 1 target. |
|
Well I think the freebsd comment dates back to #23310 so I think removing the ignores anyway is the right move. We don't have a target maintainer listed for any freebsd targets anyway, so I don't see any other way these ignores would get removed. |
|
Yeah, I think we can remove the ignores. I just wanted to point out that the tests don't actually run, because from the PR description it seemed to me like you thought they do. |
I definitely did. I should probably check all the other targets. |
saethlin
force-pushed
the
freebsd-debuginfo-tests
branch
from
1766d85
to
c6815c0
Compare
saethlin
changed the title
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 16, 2024
…r=compiler-errors Re-enable more debuginfo tests on freebsd These ignores are _ancient_, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#128598 (float to/from bits and classify: update for float semantics RFC) - rust-lang#128990 (Re-enable more debuginfo tests on freebsd) - rust-lang#129042 (Special-case alias ty during the delayed bug emission in `try_from_lit`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128990 (Re-enable more debuginfo tests on freebsd) - rust-lang#129042 (Special-case alias ty during the delayed bug emission in `try_from_lit`) - rust-lang#129086 (Stabilize `is_none_or`) - rust-lang#129149 (Migrate `validate_json.py` script to rust in `run-make/rustdoc-map-file` test) - rust-lang#129154 (Fix wrong source location for some incorrect macro definitions) - rust-lang#129161 (Stabilize std::thread::Builder::spawn_unchecked) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2024
Rollup merge of rust-lang#128990 - saethlin:freebsd-debuginfo-tests, r=compiler-errors Re-enable more debuginfo tests on freebsd These ignores are _ancient_, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.
|
Bors is not correctly removing items from the queue @bors r- |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These ignores are ancient, we don't run freebsd tests in CI, and even if we did they'd probably pass because the test suite passes with the latest gdb release on Linux.