Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #129521

Merged
merged 18 commits into from
Aug 25, 2024
Merged

Rollup of 9 pull requests #129521

merged 18 commits into from
Aug 25, 2024

Commits on Aug 17, 2024

  1. Configuration menu
    Copy the full SHA
    8b642a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Configuration menu
    Copy the full SHA
    b8eedfa View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Pin cc to 1.0.105

    `cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we
    don't drop support yet.
    
    Fixes: rust-lang#128722 (comment)
    tgross35 committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    a5f6c15 View commit details
    Browse the repository at this point in the history
  2. Implement ptr::fn_addr_eq

    Urgau committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    4325ac9 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    ebfa3e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    378902e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec0e16a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    493cf6a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53ce927 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#128596 - RalfJung:const_fn_floating_point_a…

    …rithmetic, r=nnethercote
    
    stabilize const_fn_floating_point_arithmetic
    
    Part of rust-lang#128288
    Fixes rust-lang#57241
    
    The existing test `tests/ui/consts/const_let_eq_float.rs`  ([link](https://github.com/RalfJung/rust/blob/const_fn_floating_point_arithmetic/tests/ui/consts/const_let_eq_float.rs)) covers the basics, and also Miri has extensive tests covering the interpreter's float machinery. Also, that machinery can already be used on stable inside `const`/`static` initializers, just not inside `const fn`.
    
    This was explicitly called out in rust-lang/rfcs#3514 so in a sense t-lang just recently already FCP'd this, but let's hear from them whether they want another FCP for the stabilization here or whether that was covered by the FCP for the RFC.
    Cc ``@rust-lang/lang``
    
    ### Open items
    
    - [x] Update the Reference: rust-lang/reference#1566
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    0dfdea1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#129199 - RalfJung:writes_through_immutable_…

    …pointer, r=compiler-errors
    
    make writes_through_immutable_pointer a hard error
    
    This turns the lint added in rust-lang#118324 into a hard error. This has been reported in cargo's future-compat reports since Rust 1.76 (released in February). Given that const_mut_refs is still unstable, it should be impossible to even hit this error on stable: we did accidentally stabilize some functions that can cause this error, but that got reverted in rust-lang#117905. Still, let's do a crater run just to be sure.
    
    Given that this should only affect unstable code, I don't think it needs an FCP, but let's Cc ``@rust-lang/lang`` anyway -- any objection to making this unambiguous UB into a hard error during const-eval? This can be viewed as part of rust-lang#129195 which is already nominated for discussion.
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    05b8bcc View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#129246 - BoxyUwU:feature_gate_const_arg_pat…

    …h, r=cjgillot
    
    Retroactively feature gate `ConstArgKind::Path`
    
    This puts the lowering introduced by rust-lang#125915 under a feature gate until we fix the regressions introduced by it. Alternative to whole sale reverting the PR since it didn't seem like a very clean revert and I think this is generally a step in the right direction and don't want to get stuck landing and reverting the PR over and over :)
    
    cc rust-lang#129137 ``@camelid,`` tests taken from there. beta is branching soon so I think it makes sense to not try and rush that fix through since it wont have much time to bake and if it has issues we can't simply revert it on beta.
    
    Fixes rust-lang#128016
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    c0bedb9 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#129290 - tgross35:pin-cc, r=Mark-Simulacrum

    Pin `cc` to 1.0.105
    
    `cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we don't drop support yet.
    
    Fixes: rust-lang#128722 (comment)
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2a7f2da View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#129323 - Urgau:ptr_fn_addr_eq, r=Mark-Simul…

    …acrum
    
    Implement `ptr::fn_addr_eq`
    
    This PR implements rust-lang/libs-team#323: `ptr::fn_addr_eq`.
    
    r? libs
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    2c43388 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129500 - fee1-dead-contrib:fxrel, r=compile…

    …r-errors
    
    remove invalid `TyCompat` relation for effects
    
    if the current impl uses `Maybe` (`impl const`), the parent impl must use `Maybe` (`impl const`) as well.
    
    I'd like to rename `TyCompat` to `Sub` which is probably clearer. But it would conflict with my other PR.
    
    r? ``@rust-lang/project-const-traits``
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    3f5d6b2 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129501 - RalfJung:miri-rust-backtrace, r=No…

    …ratrieb
    
    panicking: improve hint for Miri's RUST_BACKTRACE behavior
    
    Should help with rust-lang/miri#3838
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    5611b37 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129505 - RalfJung:imm-ty-offset, r=davidtwco

    interpret: ImmTy: tighten sanity checks in offset logic
    
    Also make some debug assertions into assertions. (Will need to be perf'd.)
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    9e1f628 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129510 - GrigorenkoPV:fix-elided-named-life…

    …times, r=cjgillot
    
    Fix `elided_named_lifetimes` in code
    
    rust-lang#129207 (comment)
    
    r? cjgillot
    matthiaskrgr authored Aug 24, 2024
    Configuration menu
    Copy the full SHA
    e664ff5 View commit details
    Browse the repository at this point in the history