-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #129540
Rollup of 10 pull requests #129540
Commits on Aug 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 22aa104 - Browse repository at this point
Copy the full SHA 22aa104View commit details
Commits on Aug 6, 2024
-
Add a special case for CStr/CString in the improper_ctypes lint
Instead of saying to "consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct", we now tell users to "Use `*const ffi::c_char` instead, and pass the value from `CStr::as_ptr()`" when the type involved is a `CStr` or a `CString`. Co-authored-by: Jieyou Xu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b335ec9 - Browse repository at this point
Copy the full SHA b335ec9View commit details
Commits on Aug 8, 2024
-
Detect
*
operator on!Sized
expression``` error[E0277]: the size for values of type `str` cannot be known at compilation time --> $DIR/unsized-str-in-return-expr-arg-and-local.rs:15:9 | LL | let x = *""; | ^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `str` = note: all local variables must have a statically known size = help: unsized locals are gated as an unstable feature help: references are always `Sized`, even if they point to unsized data; consider not dereferencing the expression | LL - let x = *""; LL + let x = ""; | ```
Configuration menu - View commit details
-
Copy full SHA for f6767f7 - Browse repository at this point
Copy the full SHA f6767f7View commit details
Commits on Aug 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c5e888 - Browse repository at this point
Copy the full SHA 4c5e888View commit details -
Configuration menu - View commit details
-
Copy full SHA for b968b26 - Browse repository at this point
Copy the full SHA b968b26View commit details -
Configuration menu - View commit details
-
Copy full SHA for c65ef3d - Browse repository at this point
Copy the full SHA c65ef3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62f7d53 - Browse repository at this point
Copy the full SHA 62f7d53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c6285c - Browse repository at this point
Copy the full SHA 5c6285cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5cef88c - Browse repository at this point
Copy the full SHA 5cef88cView commit details
Commits on Aug 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32e34ee - Browse repository at this point
Copy the full SHA 32e34eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f734f3d - Browse repository at this point
Copy the full SHA f734f3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 027c479 - Browse repository at this point
Copy the full SHA 027c479View commit details
Commits on Aug 25, 2024
-
Rollup merge of rust-lang#128467 - estebank:unsized-args, r=cjgillot
Detect `*` operator on `!Sized` expression The suggestion is new: ``` error[E0277]: the size for values of type `str` cannot be known at compilation time --> $DIR/unsized-str-in-return-expr-arg-and-local.rs:15:9 | LL | let x = *""; | ^ doesn't have a size known at compile-time | = help: the trait `Sized` is not implemented for `str` = note: all local variables must have a statically known size = help: unsized locals are gated as an unstable feature help: references to `!Sized` types like `&str` are `Sized`; consider not dereferencing the expression | LL - let x = *""; LL + let x = ""; | ``` Fix rust-lang#128199.
Configuration menu - View commit details
-
Copy full SHA for 0030892 - Browse repository at this point
Copy the full SHA 0030892View commit details -
Rollup merge of rust-lang#128524 - chenyukang:yukang-fix-127930-inval…
…id-outer-style-sugg, r=cjgillot Don't suggest turning crate-level attributes into outer style Fixes rust-lang#127930
Configuration menu - View commit details
-
Copy full SHA for dfe7d5c - Browse repository at this point
Copy the full SHA dfe7d5cView commit details -
Rollup merge of rust-lang#128735 - jieyouxu:pr-120176-revive, r=cjgillot
Add a special case for `CStr`/`CString` in the `improper_ctypes` lint Revives rust-lang#120176. Just needed to bless a test and fix an argument, but seemed reasonable to me otherwise. Instead of saying to "consider adding a `#[repr(C)]` or `#[repr(transparent)]` attribute to this struct", we now tell users to "Use `*const ffi::c_char` instead, and pass the value from `CStr::as_ptr()`" when the type involved is a `CStr` or a `CString`. The suggestion is not made for `&mut CString` or `*mut CString`. r? ``````@cjgillot`````` (since you were the reviewer of the original PR rust-lang#120176, but feel free to reroll)
Configuration menu - View commit details
-
Copy full SHA for 198a68d - Browse repository at this point
Copy the full SHA 198a68dView commit details -
Rollup merge of rust-lang#129429 - cjgillot:named-variance, r=compile…
…r-errors Print the generic parameter along with the variance in dumps. This allows to make sure we are testing what we think we are testing. While the tests are correct, I discovered that opaque duplicated args are in the reverse declaration order.
Configuration menu - View commit details
-
Copy full SHA for 2269381 - Browse repository at this point
Copy the full SHA 2269381View commit details -
Rollup merge of rust-lang#129430 - lolbinarycat:rustdoc-search-exact-…
…case, r=notriddle rustdoc: show exact case-sensitive matches first fixes rust-lang#119480
Configuration menu - View commit details
-
Copy full SHA for 093249a - Browse repository at this point
Copy the full SHA 093249aView commit details -
Rollup merge of rust-lang#129449 - coolreader18:pin-as_deref_mut-sign…
…ature, r=dtolnay Put Pin::as_deref_mut in impl Pin<Ptr> / rearrange Pin methods Tracking issue: rust-lang#86918 Based on the suggestion in rust-lang#86918 (comment) > Some advantages: > > * Synergy with the existing `as_ref` and `as_mut` signatures (stable since Rust 1.33) > > * Lifetime elision reduces noise in the signature > > * Turbofish less verbose: `Pin::<&mut T>::as_deref_mut` vs `Pin::<&mut Pin<&mut T>>::as_deref_mut` The comment seemed to imply that `Pin::as_ref` and `Pin::as_mut` already share an impl block, which they don't. So, I rearranged it so that they do, and we can see which looks better in the docs. <details><summary><b>Docs screenshots</b></summary> Current nightly: ![image](https://github.com/user-attachments/assets/b432cb82-8f4b-48ae-bafc-2fe49d0ad48c) `Pin::as_deref_mut` moved into the same block as `as_mut`: ![image](https://github.com/user-attachments/assets/f9b35722-6a88-4465-ad1c-28d8e91902ac) `Pin::as_ref`, `as_mut`, and `as_deref_mut` all in the same block: ![image](https://github.com/user-attachments/assets/9a1b2bf0-70a6-4751-b13f-390f1d575244) </details> I think I like the last one the most; obviously I'm biased since I'm the one who rearranged it, but it doesn't make sense to me to have `as_ref` methods split up by an `into_inner` method. r? dtolnay
Configuration menu - View commit details
-
Copy full SHA for e96faab - Browse repository at this point
Copy the full SHA e96faabView commit details -
Rollup merge of rust-lang#129481 - scottmcm:update-cb, r=tgross35
Update `compiler_builtins` to `0.1.121` To pick up rust-lang/compiler-builtins#673 and unblock rust-lang#129403 r? tgross35
Configuration menu - View commit details
-
Copy full SHA for 678193f - Browse repository at this point
Copy the full SHA 678193fView commit details -
Rollup merge of rust-lang#129482 - thomcc:add-to-review-rotation, r=j…
…ieyouxu Add myself to the review rotation for libs I am feeling better, and my new job gives me some time to do this.
Configuration menu - View commit details
-
Copy full SHA for dd05261 - Browse repository at this point
Copy the full SHA dd05261View commit details -
Rollup merge of rust-lang#129492 - tshepang:patch-2, r=chenyukang
Make wasm32 platform support docs easier to read
Configuration menu - View commit details
-
Copy full SHA for 2412d3c - Browse repository at this point
Copy the full SHA 2412d3cView commit details -
Rollup merge of rust-lang#129512 - lolbinarycat:linkchecker-impl-docs…
…, r=ehuss update the doc comment on lintchecker b/c it parses html now
Configuration menu - View commit details
-
Copy full SHA for 11ebb59 - Browse repository at this point
Copy the full SHA 11ebb59View commit details