Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prereq3 for async drop - LangItem registration for async_drop_in_place()::{{closure0}} #129737

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Aug 29, 2024

This is subpart 3 PR of #123948, just for review purposes.
We have async_drop_in_place lang item for async fn async_drop_in_place<T>(...).

#[lang = "async_drop_in_place"]
pub async unsafe fn async_drop_in_place<T: ?Sized>(_to_drop: *mut T) { ... }

But we also need to generate shim for its returning value - coroutine async_drop_in_place<T>::{{closure0}}.
So, we need to bind some lang item to it. This patch registers LangItem::AsyncDropInPlacePoll for coroutine, when its constructor function is LangItem::AsyncDropInPlace.

Review only last commit, based on previous PR #129736

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 29, 2024
@rustbot
Copy link
Collaborator

rustbot commented Aug 29, 2024

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

This PR changes MIR

cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@azhogin azhogin marked this pull request as draft August 30, 2024 07:24
@azhogin azhogin force-pushed the azhogin/async-drop-prereq3-lang-item-for-drop-poll branch from 7a0329a to 3c5bee0 Compare August 30, 2024 07:27
@azhogin azhogin force-pushed the azhogin/async-drop-prereq3-lang-item-for-drop-poll branch from 3c5bee0 to d8c1a84 Compare September 7, 2024 12:24
@azhogin azhogin force-pushed the azhogin/async-drop-prereq3-lang-item-for-drop-poll branch from d8c1a84 to 50aea7e Compare September 8, 2024 12:02
@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts.

@davidtwco
Copy link
Member

r? @nikomatsakis is going to look into this

@rustbot rustbot assigned nikomatsakis and unassigned davidtwco Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants