Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 1.83 #129790

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Bump to 1.83 #129790

merged 1 commit into from
Sep 1, 2024

Conversation

BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Aug 30, 2024

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Aug 30, 2024
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Aug 30, 2024

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Aug 30, 2024

📌 Commit 4d272b1 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 30, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2024
@BoxyUwU BoxyUwU assigned BoxyUwU and unassigned Mark-Simulacrum Aug 30, 2024
@bors
Copy link
Contributor

bors commented Sep 1, 2024

⌛ Testing commit 4d272b1 with merge 43eaa5c...

@bors
Copy link
Contributor

bors commented Sep 1, 2024

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 43eaa5c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 1, 2024
@bors bors merged commit 43eaa5c into rust-lang:master Sep 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (43eaa5c): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.0% [0.8%, 3.1%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.6% [-1.9%, -0.3%] 12
All ❌✅ (primary) 2.0% [0.8%, 3.1%] 2

Max RSS (memory usage)

Results (primary 0.4%, secondary 0.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.8% [0.4%, 4.7%] 51
Regressions ❌
(secondary)
0.9% [0.4%, 2.7%] 62
Improvements ✅
(primary)
-0.8% [-1.9%, -0.4%] 15
Improvements ✅
(secondary)
-0.8% [-2.0%, -0.4%] 20
All ❌✅ (primary) 0.4% [-1.9%, 4.7%] 66

Cycles

Results (primary 0.4%, secondary -0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.1% [0.4%, 4.1%] 21
Regressions ❌
(secondary)
1.0% [0.4%, 3.0%] 43
Improvements ✅
(primary)
-1.1% [-4.6%, -0.5%] 9
Improvements ✅
(secondary)
-1.3% [-5.3%, -0.4%] 54
All ❌✅ (primary) 0.4% [-4.6%, 4.1%] 30

Binary size

Results (primary 0.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.7% [0.7%, 0.7%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.7% [0.7%, 0.7%] 1

Bootstrap: 789.249s -> 789.934s (0.09%)
Artifact size: 338.76 MiB -> 338.74 MiB (-0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants