Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #129915

Merged
merged 25 commits into from
Sep 3, 2024
Merged

Rollup of 12 pull requests #129915

merged 25 commits into from
Sep 3, 2024

Commits on Aug 29, 2024

  1. Configuration menu
    Copy the full SHA
    05ffd44 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Configuration menu
    Copy the full SHA
    175238b View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    0e5628d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32a30dd View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    5780c1c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ac69544 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00de006 View commit details
    Browse the repository at this point in the history
  4. Remove stray word in a comment

    alex committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    06e3552 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7494224 View commit details
    Browse the repository at this point in the history
  6. mailmap: add new email for davidtwco

    Signed-off-by: David Wood <[email protected]>
    davidtwco committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    7ac5fda View commit details
    Browse the repository at this point in the history
  7. mailmapper?

    BoxyUwU committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    5d47b4d View commit details
    Browse the repository at this point in the history
  8. Remove kobzol vacation status

    Kobzol committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    fa77b9d View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    8be9fed View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#129748 - RalfJung:box-validity, r=workingju…

    …bilee
    
    Box validity: update for new zero-sized rules
    
    Fixes rust-lang/unsafe-code-guidelines#529
    
    Cc `@joshlf` `@rust-lang/opsem`
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    003ddec View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#129829 - compiler-errors:decode-non-optiona…

    …l, r=lcnr
    
    Make decoding non-optional `LazyArray` panic if not set
    
    Tables may be [defined](https://github.com/rust-lang/rust/blob/9649706eada1b2c68cf6504356efb058f68ad739/compiler/rustc_metadata/src/rmeta/mod.rs#L377) as `optional:` or `defaulted:`. If optional, if we try to read a value from a key that was never encoded, we should panic. This has high value in ensuring correctness over a defaulted table, so the tradeoff is worth considering, since it signals the compiler has a buggy encode impl, rather than just defaulting to a value.
    
    HOWEVER, `optional:` arrays were side-stepping this. So this PR fixes that, and makes `optional:` tables of `LazyArray` act like `LazyValue`, and panic if it's not assigned a value during encoding.
    
    During this PR, I found that `deduced_param_attrs` has buggy (?? i think??) implementation where it will refuse to encode cross-crate `deduced_param_attrs` unless we're codegening, we're optimizing the library, and incremental is disabled. This seems incredibly wrong, but I don't want to fix it in this PR.
    https://github.com/rust-lang/rust/blob/9649706eada1b2c68cf6504356efb058f68ad739/compiler/rustc_metadata/src/rmeta/encoder.rs#L1733-L1747
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c6410f5 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#129856 - RalfJung:compiler_fence, r=thomcc

    compiler_fence documentation: emphasize synchronization, not reordering
    
    Our `fence` docs have at some point been update to explain that they are about synchronization, not about "preventing reordering". This updates the `compiler_fence` docs n the same vein, mostly by referring to the `fence` docs.
    
    The old docs make it sound like I can put a compiler_fence in the middle of a bunch of non-atomic operations and that would achieve any kind of guarantee. It does not, atomic operations are still required to do synchronization.
    
    I also slightly tweaked the `fence` docs, to put the synchronization first and the "prevent reordering" second.
    
    Cc `@rust-lang/opsem` `@chorman0773` `@m-ou-se`
    
    Fixes rust-lang#129189
    Fixes rust-lang#54962
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f0072bf View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#129868 - Kobzol:kobzol-vacation-remove, r=lqd

    Remove kobzol vacation status
    
    Conflicts with rust-lang#129843, so should be merged after it.
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    912931d View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#129875 - Sajjon:sajjon_fix_typos_batch_1, r…

    …=compiler-errors,jieyouxu
    
    chore: Fix typos in 'compiler' (batch 1)
    
    Batch 1/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    cfb1271 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#129877 - Sajjon:sajjon_fix_typos_batch_2, r…

    …=fee1-dead
    
    chore: Fix typos in 'compiler' (batch 2)
    
    Batch 2/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    1d9eb9d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#129878 - Sajjon:sajjon_fix_typos_batch_3, r…

    …=jieyouxu
    
    chore: Fix typos in 'compiler' (batch 3)
    
    Batch 3/3: Fixes typos in `compiler`
    
    (See [issue](rust-lang#129874) tracking all PRs with typos fixes)
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    929b308 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#129890 - alex:patch-1, r=workingjubilee

    Remove stray word in a comment
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3ddf061 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#129892 - oskgo:clarify-slice-from-raw, r=Ra…

    …lfJung
    
    Clarify language around ptrs in slice::raw
    
    More specifically we explicitly mention that the pointer should be non-null as a top level requirement. Nullptrs are always valid for zero sized operations, so just validity (and alignment) does not guarantee non-nullness as implied in the existing docs.
    
    We also explicitly call out ZSTs as an additional example where perhaps unintuitively alignment and non-nullness still have to hold.
    
    Finally we change `data` in the range functions to `start`, which seems like a typo to me.
    
    Touches docs for rust-lang#89792
    
    r? RalfJung
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9dad90a View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#129905 - davidtwco:update-davidtwco-mailmap…

    …, r=lqd
    
    mailmap: add new email for davidtwco
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f065302 View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#129906 - BoxyUwU:boxy_mailmap, r=lqd

    mailmapper?
    
    I think I have done this right? lol
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b1b8e3e View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#129907 - saethlin:solid-io-error, r=WaffleL…

    …apkin
    
    Fix compile error in solid's remove_dir_all
    
    Before this PR, `x check library/std --target=aarch64-kmc-solid_asp3` will fail with:
    ```
    error[E0382]: use of partially moved value: `result`
       --> std/src/sys/pal/solid/fs.rs:544:20
        |
    541 |         if let Err(err) = result
        |                    --- value partially moved here
    ...
    544 |             return result;
        |                    ^^^^^^ value used here after partial move
        |
        = note: partial move occurs because value has type `io::error::Error`, which does not implement the `Copy` trait
    help: borrow this binding in the pattern to avoid moving the value
        |
    541 |         if let Err(ref err) = result
        |                    +++
    
    ```
    
    cc `@kawadakk` I think this will clear up https://solid-rs.github.io/toolstate/ :)
    matthiaskrgr committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    d6298d3 View commit details
    Browse the repository at this point in the history