Rename Receiver -> LegacyReceiver #130225
Open
+63
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
9 tasks
|
@rustbot label +S-waiting-on-author -S-waiting-on-review |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
adetaylor
force-pushed
the
rename-old-receiver
branch
from
9a47840
to
827306a
Compare
This comment has been minimized.
This comment has been minimized.
adetaylor
force-pushed
the
rename-old-receiver
branch
from
827306a
to
7614901
Compare
This comment has been minimized.
This comment has been minimized.
adetaylor
force-pushed
the
rename-old-receiver
branch
from
7614901
to
9040bb1
Compare
This comment has been minimized.
This comment has been minimized.
adetaylor
force-pushed
the
rename-old-receiver
branch
from
9040bb1
to
dd2218c
Compare
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #130724) made this pull request unmergeable. Please resolve the merge conflicts. |
wesleywiser
approved these changes
Oct 11, 2024
|
r? libs |
|
Looks like some name change was approved by the RFC, so I don't need to punt to a team, and I don't have strong feelings towards anything. This needs a rebase, but otherwise r=me and wesleywiser. @bors delegate+ |
|
✌️ @adetaylor, you can now approve this pull request! If @jhpratt told you to " |
rustbot
added
has-merge-commits
|
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands: The following commits are merge commits: |
This comment has been minimized.
This comment has been minimized.
As part of the "arbitrary self types v2" project, we are going to replace the current `Receiver` trait with a new mechanism based on a new, different `Receiver` trait. This PR renames the old trait to get it out the way. Naming is hard. Options considered included: * HardCodedReceiver (because it should only be used for things in the standard library, and hence is sort-of hard coded) * LegacyReceiver * TargetLessReceiver * OldReceiver These are all bad names, but fortunately this will be temporary. Assuming the new mechanism proceeds to stabilization as intended, the legacy trait will be removed altogether. Although we expect this trait to be used only in the standard library, we suspect it may be in use elsehwere, so we're landing this change separately to identify any surprising breakages. It's known that this trait is used within the Rust for Linux project; a patch is in progress to remove their dependency. This is a part of the arbitrary self types v2 project, rust-lang/rfcs#3519 rust-lang#44874 r? @wesleywiser
adetaylor
force-pushed
the
rename-old-receiver
branch
from
fc5e6cc
to
20d50af
Compare
rustbot
removed
has-merge-commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the "arbitrary self types v2" project, we are going to replace the current
Receivertrait with a new mechanism based on a new, differentReceivertrait.This PR renames the old trait to get it out the way. Naming is hard. Options considered included:
These are all bad names, but fortunately this will be temporary. Assuming the new mechanism proceeds to stabilization as intended, the legacy trait will be removed altogether.
Although we expect this trait to be used only in the standard library, we suspect it may be in use elsehwere, so we're landing this change separately to identify any surprising breakages.
It's known that this trait is used within the Rust for Linux project; a patch is in progress to remove their dependency.
This is a part of the arbitrary self types v2 project,
rust-lang/rfcs#3519
#44874
r? @wesleywiser