-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add InProgress ErrorKind gated behind io_error_inprogress feature #130789
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Noratrieb (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
This comment has been minimized.
This comment has been minimized.
nice, could you squash the commits together? you've got my approval afterwards 🐱 |
f58f984
to
8450fcc
Compare
Done :) |
3ce7afa
to
60eddc6
Compare
Co-authored-by: David Tolnay <[email protected]> Co-authored-by: nora <[email protected]>
9997343
to
46fd76e
Compare
thanks! |
Rollup of 7 pull requests Successful merges: - rust-lang#130234 (improve compile errors for invalid ptr-to-ptr casts with trait objects) - rust-lang#130752 (Improve assembly test for CMSE ABIs) - rust-lang#130764 (Separate collection of crate-local inherent impls from error tracking) - rust-lang#130788 (Pin memchr to 2.5.0 in the library rather than rustc_ast) - rust-lang#130789 (add InProgress ErrorKind gated behind io_error_inprogress feature) - rust-lang#130793 (Mention `COMPILETEST_VERBOSE_CRASHES` on crash test failure) - rust-lang#130798 (rustdoc: inherit parent's stability where applicable) Failed merges: - rust-lang#130735 (Simple validation for unsize coercion in MIR validation) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#130789 - aviramha:add_inprogress, r=Noratrieb add InProgress ErrorKind gated behind io_error_inprogress feature Follow up on rust-lang/libs-team#92 (comment)
Should a tracking issue be created? |
you are absolutely correct, I noticed that during review and then forgot to comment about it, thanks. |
no, let me do that for you |
I put up #130842 |
…s, r=jieyouxu Add tracking issue for io_error_inprogress I forgot to mention this in rust-lang#130789
Rollup merge of rust-lang#130842 - Noratrieb:tracking-issue-inprogress, r=jieyouxu Add tracking issue for io_error_inprogress I forgot to mention this in rust-lang#130789
Follow up on rust-lang/libs-team#92 (comment)