Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compiler-builtins to 0.1.130 #130792

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Update compiler-builtins to 0.1.130 #130792

merged 1 commit into from
Sep 28, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Sep 24, 2024 •
edited
Loading

This includes the following which add __divtf3 and __powtf2, and do some feature cleanup:

The cc bump 1 was previously included but was reverted due to problems updating.

r? @Amanieu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor Author

tgross35 commented Sep 24, 2024 •
edited
Loading

Ah I guess we don't have naked_asm in bootstrap yet, so this is effectively blocked on #128651 (which actually bumps this as well, only to 0.1.126 though).

@tgross35 tgross35 added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2024
@tgross35 tgross35 mentioned this pull request Sep 25, 2024
Closed
@arttet arttet mentioned this pull request Sep 26, 2024
Merged
@bors
Copy link
Contributor

bors commented Sep 27, 2024

☔ The latest upstream changes (presumably #130919) made this pull request unmergeable. Please resolve the merge conflicts.

@tgross35
Copy link
Contributor Author

The naked_asm update was merged in #130875, and I reverted the cc change since that update has been problematic. This only contains __divtf3 now.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Sep 27, 2024
@tgross35 tgross35 changed the title Update compiler_builtins to 0.1.127 Update compiler_builtins to 0.1.129 Sep 27, 2024
@Amanieu
Copy link
Member

Amanieu commented Sep 28, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit 134d5a1 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2024
@tgross35 tgross35 mentioned this pull request Sep 28, 2024
Merged
@tgross35
Copy link
Contributor Author

@bors r-

There are a couple other small additions coming, we might as well update at once.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2024
@tgross35 tgross35 changed the title Update compiler_builtins to 0.1.129 Update compiler_builtins to 0.1.130 Sep 28, 2024
@tgross35 tgross35 changed the title Update compiler_builtins to 0.1.130 Update compiler-builtins to 0.1.130 Sep 28, 2024
@tgross35
Update compiler_builtins to 0.1.130
fd36e8b 
This includes the following which add `__divtf3` and `__powtf2`, and do
some feature cleanup:

- rust-lang/compiler-builtins#622
- rust-lang/compiler-builtins#692
- rust-lang/compiler-builtins#614
- rust-lang/compiler-builtins#694

The `cc` bump [1] was previously included but was reverted due to
problems updating.

[1]: rust-lang/compiler-builtins#690
@tgross35
Copy link
Contributor Author

Amanieu approved rust-lang/compiler-builtins#614 and rust-lang/compiler-builtins#694 in the builtins repo.

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit 15efdb5 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2024
@tgross35
Copy link
Contributor Author

@bors r=Amanieu

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit fd36e8b has been approved by Amanieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 28, 2024

⌛ Testing commit fd36e8b with merge a1fd235...

@bors
Copy link
Contributor

bors commented Sep 28, 2024

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing a1fd235 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2024
@bors bors merged commit a1fd235 into rust-lang:master Sep 28, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 28, 2024
@tgross35 tgross35 deleted the update-builtins branch September 28, 2024 20:22
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a1fd235): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -1.4% [-1.4%, -1.4%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -1.4% [-1.4%, -1.4%] 1

Cycles

Results (secondary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.814s -> 769.092s (0.04%)
Artifact size: 341.35 MiB -> 341.40 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tgross35 @rustbot @rust-log-analyzer @bors @Amanieu @rust-timer