Add from_ref and from_mut constructors to core::ptr::NonNull.
#130822
+97
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
4 tasks
bjoernager
force-pushed
the
non-null-from-ref
branch
from
043987d
to
2a97fdd
Compare
This comment has been minimized.
This comment has been minimized.
bjoernager
force-pushed
the
non-null-from-ref
branch
from
2a97fdd
to
1e39e34
Compare
This comment has been minimized.
This comment has been minimized.
clubby789
reviewed
Sep 25, 2024
|
This will need an ACP, or at least libs-api signoff. An ACP is just an issue template at https://github.com/rust-lang/libs-team/.
Should probably be moved to its own commit to keep updates from that and updates from the new API separate (e.g. the MIR test needs to be blessed) |
bjoernager
force-pushed
the
non-null-from-ref
branch
from
1e39e34
to
1bcb831
Compare
|
I've removed the |
This comment has been minimized.
This comment has been minimized.
bjoernager
force-pushed
the
non-null-from-ref
branch
from
1bcb831
to
94ab726
Compare
dtolnay
added
T-libs-api
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#130822 (Add `from_ref` and `from_mut` constructors to `core::ptr::NonNull`.) - rust-lang#131381 (Implement edition 2024 match ergonomics restrictions) - rust-lang#131594 (rustdoc: Rename "object safe" to "dyn compatible") - rust-lang#131686 (Add fast-path when computing the default visibility) - rust-lang#131699 (Try to improve error messages involving aliases in the solver) - rust-lang#131757 (Ignore lint-non-snake-case-crate#proc_macro_ on targets without unwind) - rust-lang#131783 (Fix explicit_iter_loop in rustc_serialize) - rust-lang#131788 (Fix mismatched quotation mark) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 16, 2024
Rollup merge of rust-lang#130822 - bjoernager:non-null-from-ref, r=dtolnay Add `from_ref` and `from_mut` constructors to `core::ptr::NonNull`. Relevant tracking issue: rust-lang#130823 The `core::ptr::NonNull` type should have the convenience constructors `from_ref` and `from_mut` for parity with `core::ptr::from_ref` and `core::ptr::from_mut`. Although the type in question already implements `From<&T>` and `From<&mut T>`, these new functions also carry the ability to be used in constant expressions (due to not being behind a trait).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant tracking issue: #130823
The
core::ptr::NonNulltype should have the convenience constructorsfrom_refandfrom_mutfor parity withcore::ptr::from_refandcore::ptr::from_mut.Although the type in question already implements
From<&T>andFrom<&mut T>, these new functions also carry the ability to be used in constant expressions (due to not being behind a trait).