-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Compute RUST_EXCEPTION_CLASS
from native-endian bytes
#130897
Conversation
This makes it appear correctly in hexdumps on both LE and BE platforms.
Nice. Not going to rollup this in case it causes issues and is needed to be identified in a bisection. @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (150247c): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 2.9%, secondary -2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -2.5%, secondary 6.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 771.075s -> 771.117s (0.01%) |
Note that the Itanium exception ABI says that the convention is that high bit are for vendor and low bits are for language: https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html. Perhaps put a relnote to say that the langauge is now renamed to MOZ? ;) |
This was changed in upstream Rust recently [1], so change to follow suit. The error message is slightly different between exception from another Rust runtime and a complete foreign exception. (The message for later is a confusing "Rust exception must be rethrown"). Link: rust-lang/rust#130897 [1]
This was changed in upstream Rust recently [1], so change to follow suit. The error message is slightly different between exception from another Rust runtime and a complete foreign exception. (The message for later is a confusing "Rust exception must be rethrown"). Link: rust-lang/rust#130381 [1]
✔️ MOZ from RUST |
More like ZOM, no? "The low 4 bytes" would have a different order on little-endian than on big-endian. If all other languages use |
Cc @rust-lang/libs |
This was changed in upstream Rust recently [1], so change to follow suit. The error message is slightly different between exception from another Rust runtime and a complete foreign exception. (The message for latter is a confusing "Rust exception must be rethrown"). Link: rust-lang/rust#130897 [1]
This makes it appear correctly in hexdumps on both LE and BE platforms.
As discussed extensively in https://github.com/rust-lang/rust/pull/130381/files#r1760034980