-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: aarch64-gnu-debug job #131207
base: master
Are you sure you want to change the base?
ci: aarch64-gnu-debug job #131207
Conversation
Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested).
Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together.
This PR modifies cc @jieyouxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test itself LGTM
@bors r+ This seems OK to me. |
…-Simulacrum ci: aarch64-gnu-debug job - Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested). - Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together. r? `@Mark-Simulacrum`
Rollup of 7 pull requests Successful merges: - rust-lang#131120 (Stabilize `const_option`) - rust-lang#131207 (ci: aarch64-gnu-debug job) - rust-lang#131334 (Enable sanitizers for loongarch64-unknown-*) - rust-lang#131358 (force "HEAD" for non-CI and `git_upstream_merge_base` for CI environment) - rust-lang#131418 (Use throw intrinsic from stdarch in wasm libunwind) - rust-lang#131579 (Remap path prefix in the panic message of `tests/ui/meta/revision-bad.rs`) - rust-lang#131591 (add latest crash tests) r? `@ghost` `@rustbot` modify labels: rollup
Do we have a limit on the number of runners that handle arm jobs? The auto job is about an hour in and https://github.com/rust-lang-ci/rust/actions/runs/11309982802/job/31454499991 still says "Job is waiting for a runner from 'ubuntu-22.04-arm64-8core-32gb' to come online." for the existing aarch64-gnu job. |
Looks like this failed the rollup #131630 (comment). @bors r- Regarding my above message - the original aarch64-gnu job did eventually start, just about an hour later than everything else. |
@Mark-Simulacrum do you know whether we do have a limit on these runners or why it would be slow to start? |
There should be 50(?) runners worth of concurrency of this particular runner, so I doubt that was the problem. Looking back it looks like the job did eventually run, maybe this was fallout from the github problems last week (IIRC)? I'd suggest we just retry. |
@bors r=Mark-Simulacrum |
Did something land to fix the cross-lang-lto failure on this job from the rollup? |
FTR, the failure was
|
That test was previously only ever exercised on the x86_64-debug counterpart, so presumably that is still going to fail. If some cases need to be arch specific, they'll need to be guarded by |
Just to have isolated logs @bors try |
ci: aarch64-gnu-debug job - Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested). - Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together. r? `@Mark-Simulacrum` try-job: aarch64-gnu-debug
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
--enable-debug
and tests thatneeds-force-clang-based-tests
pass (where cross-language LTO is tested).-Zbranch-protection=pac-ret
and cross-language LTO work together.r? @Mark-Simulacrum
try-job: aarch64-gnu-debug