Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable f16 and f128 on windows-gnullvm targets #131308

Merged
merged 1 commit into from
Oct 7, 2024
Merged

enable f16 and f128 on windows-gnullvm targets #131308

merged 1 commit into from
Oct 7, 2024
+3 −2

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Oct 5, 2024

Continuation of #130959

@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2024
@mati865
Copy link
Contributor Author

mati865 commented Oct 5, 2024 •
edited
Loading

r? @tgross35

The tests/ pass locally so I think it works fine.

@rustbot rustbot assigned tgross35 and unassigned Mark-Simulacrum Oct 5, 2024
@tgross35
Copy link
Contributor

tgross35 commented Oct 6, 2024

Thanks for the follow up! I don't think we test these in CI, so as long as they work locally that should be enough.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2024

📌 Commit 9d2495d has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2024
@Zalathar Zalathar mentioned this pull request Oct 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2024
@bors
Auto merge of rust-lang#131345 - Zalathar:rollup-scdxuou, r=Zalathar
690332a 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#128399 (liballoc: introduce String, Vec const-slicing)
 - rust-lang#131308 (enable f16 and f128 on windows-gnullvm targets)
 - rust-lang#131325 (coverage: Multiple small tweaks to counter creation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5c1c49a into rust-lang:master Oct 7, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 7, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2024
@rust-timer
Unrolled build for rust-lang#131308
a7a0929 
Rollup merge of rust-lang#131308 - mati865:gnullvm-f16-f128, r=tgross35

enable f16 and f128 on windows-gnullvm targets

Continuation of rust-lang#130959
@mati865 mati865 deleted the gnullvm-f16-f128 branch October 7, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mati865 @rustbot @tgross35 @bors @Mark-Simulacrum