Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for runtest::check_rustdoc_test_option method #131353

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add documentation for runtest::check_rustdoc_test_option method #131353

merged 1 commit into from
Oct 7, 2024

Conversation

GuillaumeGomez
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

Could not assign reviewer from: jieyouxu.
User(s) jieyouxu are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 7, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 7, 2024

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@jieyouxu jieyouxu assigned jieyouxu and unassigned Kobzol Oct 7, 2024
jieyouxu
jieyouxu approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

jieyouxu commented Oct 7, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 7, 2024

📌 Commit dde78bd has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2024
@bors
Auto merge of rust-lang#131354 - matthiaskrgr:rollup-hprnng2, r=matth…
7caad69 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131331 (Revert "warn_old_master_branch" check)
 - rust-lang#131344 (Avoid `&Lrc<T>` in various places)
 - rust-lang#131346 (Restrict `ignore-mode-*` directives)
 - rust-lang#131353 (Add documentation for `runtest::check_rustdoc_test_option` method)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fd2278d into rust-lang:master Oct 7, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2024
@rust-timer
Unrolled build for rust-lang#131353
392b2d9 
Rollup merge of rust-lang#131353 - GuillaumeGomez:check_rustdoc_test_option, r=jieyouxu

Add documentation for `runtest::check_rustdoc_test_option` method

r? `@jieyouxu`
@rustbot rustbot added this to the 1.83.0 milestone Oct 7, 2024
@GuillaumeGomez GuillaumeGomez deleted the check_rustdoc_test_option branch October 7, 2024 14:44
@jieyouxu jieyouxu added the A-compiletest Area: The compiletest test runner label Oct 9, 2024
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
@bors
Auto merge of rust-lang#131354 - matthiaskrgr:rollup-hprnng2, r=matth…
65d941d 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131331 (Revert "warn_old_master_branch" check)
 - rust-lang#131344 (Avoid `&Lrc<T>` in various places)
 - rust-lang#131346 (Restrict `ignore-mode-*` directives)
 - rust-lang#131353 (Add documentation for `runtest::check_rustdoc_test_option` method)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Done
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @jieyouxu @bors @Kobzol