Stabilize const_maybe_uninit_write
#131713
Open
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
The other methods from #63567 have already been stabilized, but this needs FCP. I will be able to drop the enable for |
tgross35
added
needs-fcp
GKFX
reviewed
Oct 16, 2024
library/core/src/mem/maybe_uninit.rs
Outdated
| #[inline(always)] | ||
| #[stable(feature = "maybe_uninit_write", since = "1.55.0")] | ||
| #[cfg_attr(bootstrap, rustc_allow_const_fn_unstable(const_mut_refs))] |
There was a problem hiding this comment.
It should be possible to remove the rustc_allow_const_fn_unstable now the stage0 compiler has been updated.
|
☔ The latest upstream changes (presumably #131887) made this pull request unmergeable. Please resolve the merge conflicts. |
Mark the following API const stable:
impl<T> MaybeUninit<T> {
pub const fn write(&mut self, val: T) -> &mut T;
}
This depends on `const_mut_refs` and `const_maybe_uninit_assume_init`,
both of which have recently been stabilized.
Tracking issue: <rust-lang#63567>
tgross35
force-pushed
the
stabilize-const_maybe_uninit_write
branch
from
1ed32c5
to
7808838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the following API const stable:
This depends on
const_mut_refsandconst_maybe_uninit_assume_init, both of which have recently been stabilized.Closes: #63567
r? libs-api