Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated documentation for repeat_n #131858

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Remove outdated documentation for repeat_n #131858

merged 1 commit into from
Oct 18, 2024
+1 −3

Conversation

AnthonyMikh
Copy link
Contributor

After #106943, which made Take<Repeat<I>> implement ExactSizeIterator, part of documentation about difference from repeat(x).take(n) is no longer valid.

@rustbot labels: +A-docs, +A-iterators

@AnthonyMikh
remove outdated documentation for repeat_n
cdacdae 
After rust/rust-lang#106943 the part about `ExactSizeIterator` is no longer valid
@rustbot
Copy link
Collaborator

rustbot commented Oct 17, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-iterators Area: Iterators labels Oct 17, 2024
@schuelermine schuelermine mentioned this pull request Oct 17, 2024
Closed
@jhpratt
Copy link
Member

jhpratt commented Oct 18, 2024

LGTM, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 18, 2024

📌 Commit cdacdae has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 18, 2024
@jhpratt
Rollup merge of rust-lang#131858 - AnthonyMikh:AnthonyMikh/repeat_n-i…
6c9bbaf 
…s-not-that-special-anymore, r=jhpratt

Remove outdated documentation for `repeat_n`

After rust-lang#106943, which made `Take<Repeat<I>>` implement `ExactSizeIterator`, part of documentation about difference from `repeat(x).take(n)` is no longer valid.

`@rustbot` labels: +A-docs, +A-iterators
@jhpratt jhpratt mentioned this pull request Oct 18, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
@bors
Auto merge of rust-lang#131868 - jhpratt:rollup-m20556e, r=jhpratt
b9805d9 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#131809 (Fix predicate signatures in retain_mut docs)
 - rust-lang#131858 (Remove outdated documentation for `repeat_n`)
 - rust-lang#131866 (Avoid use imports in `thread_local_inner!`)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 18, 2024
@jhpratt
Rollup merge of rust-lang#131858 - AnthonyMikh:AnthonyMikh/repeat_n-i…
17376f2 
…s-not-that-special-anymore, r=jhpratt

Remove outdated documentation for `repeat_n`

After rust-lang#106943, which made `Take<Repeat<I>>` implement `ExactSizeIterator`, part of documentation about difference from `repeat(x).take(n)` is no longer valid.

``@rustbot`` labels: +A-docs, +A-iterators
@jhpratt jhpratt mentioned this pull request Oct 18, 2024
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 18, 2024
@jhpratt
Rollup merge of rust-lang#131858 - AnthonyMikh:AnthonyMikh/repeat_n-i…
c4edbb2 
…s-not-that-special-anymore, r=jhpratt

Remove outdated documentation for `repeat_n`

After rust-lang#106943, which made `Take<Repeat<I>>` implement `ExactSizeIterator`, part of documentation about difference from `repeat(x).take(n)` is no longer valid.

```@rustbot``` labels: +A-docs, +A-iterators
@jhpratt jhpratt mentioned this pull request Oct 18, 2024
Closed
@jieyouxu jieyouxu mentioned this pull request Oct 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
@bors
Auto merge of rust-lang#131887 - jieyouxu:rollup-ftik4ni, r=jieyouxu
1350eea 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#130136 (Partially stabilize const_pin)
 - rust-lang#131755 (Regression test for AVR `rjmp` offset)
 - rust-lang#131774 (Add getentropy for RTEMS)
 - rust-lang#131802 (Dont ICE when computing coverage of synthetic async closure body)
 - rust-lang#131809 (Fix predicate signatures in retain_mut docs)
 - rust-lang#131858 (Remove outdated documentation for `repeat_n`)
 - rust-lang#131866 (Avoid use imports in `thread_local_inner!`)
 - rust-lang#131874 (Default to the medium code model on OpenHarmony LoongArch target)
 - rust-lang#131877 (checktools.sh: add link to issue for more context about disabled Miri tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 64bf99b into rust-lang:master Oct 18, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 18, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 18, 2024
@rust-timer
Unrolled build for rust-lang#131858
34c2c38 
Rollup merge of rust-lang#131858 - AnthonyMikh:AnthonyMikh/repeat_n-is-not-that-special-anymore, r=jhpratt

Remove outdated documentation for `repeat_n`

After rust-lang#106943, which made `Take<Repeat<I>>` implement `ExactSizeIterator`, part of documentation about difference from `repeat(x).take(n)` is no longer valid.

````@rustbot```` labels: +A-docs, +A-iterators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-iterators Area: Iterators S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
5 participants
@AnthonyMikh @rustbot @jhpratt @bors @Mark-Simulacrum