Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Improve docs for mod 'result' #13499

Merged
merged 2 commits into from
Apr 17, 2014
Merged

std: Improve docs for mod 'result' #13499

merged 2 commits into from
Apr 17, 2014

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 13, 2014

This adds some fairly extensive documentation for Result.

I'm using manual links to other rustdoc html pages a bit.

//!
//! Functions return `Result` whenever errors are expected and
//! recoverable. In the `std` crate `Result` is most prominently used
//! for [I/O](../io/index.html).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a way of cross linking docs the right way :(

@alexcrichton
Copy link
Member

This looks pretty awesome!

@brson
Copy link
Contributor Author

brson commented Apr 15, 2014

I've addressed feedback, but left the two sections that @sfackler thought should go elsewhere.

@alexcrichton
Copy link
Member

r=me with a nit and a rebase

bors added a commit that referenced this pull request Apr 17, 2014
This adds some fairly extensive documentation for `Result`.

I'm using manual links to other rustdoc html pages a bit.
@bors bors closed this Apr 17, 2014
@bors bors merged commit e69bd81 into rust-lang:master Apr 17, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Nov 16, 2022
Fix `tt::Punct`'s spacing calculation

Fixes rust-lang#13499

We currently set a `tt::Punct`'s spacing to `Spacing::Joint` unless its next token is a trivia (i.e. whitespaces or comment). As I understand it, rustc only [sets `Spacing::Joint` if the next token is an operator](https://github.com/rust-lang/rust/blob/5b3e9090757da9a95b22f589fe39b6a4b5455b96/compiler/rustc_parse/src/lexer/tokentrees.rs#L77-L78) and we should follow it to guarantee the consistent behavior of proc macros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants